Re: [PATCH v6 1/4] libfdt: Add new errors for the overlay code

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]

On Thu, Sep 29, 2016 at 01:29:05PM +0200, Maxime Ripard wrote:
> Add a few new error codes to report the failure conditions we might
> encounter in the overlay application code:
>    - FDT_ERR_BADFIXUP, when an overlay fixup property is not properly
>      formatted.
>    - FDT_ERR_BADOVERLAY, when an overlay cannot be parsed, even though its
>      structure is correct

So, my thought had been to combine all problems with the overlay for
fixup formatting into a single error code BADOVERLAY.

I'm not opposed to splitting that up more, but there should be a
coherent guideline about what's BADFIXUP and what's BADOVERLAY.

>    - FDT_ERR_NOPHANDLES, when we ran out of available phandles and we
>      cannot use a new phandle without either using an invalid one (-1 or
>      0), or one already used.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
>  libfdt/fdt_strerror.c |  3 +++
>  libfdt/libfdt.h       | 15 ++++++++++++++-
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/libfdt/fdt_strerror.c b/libfdt/fdt_strerror.c
> index e6c3ceee8c58..70a36291466f 100644
> --- a/libfdt/fdt_strerror.c
> +++ b/libfdt/fdt_strerror.c
> @@ -76,6 +76,9 @@ static struct fdt_errtabent fdt_errtable[] = {
>  	FDT_ERRTABENT(FDT_ERR_BADVERSION),
>  	FDT_ERRTABENT(FDT_ERR_BADSTRUCTURE),
>  	FDT_ERRTABENT(FDT_ERR_BADLAYOUT),
> +	FDT_ERRTABENT(FDT_ERR_BADFIXUP),
> +	FDT_ERRTABENT(FDT_ERR_BADOVERLAY),
> +	FDT_ERRTABENT(FDT_ERR_NOPHANDLES),
>  };
>  #define FDT_ERRTABSIZE	(sizeof(fdt_errtable) / sizeof(fdt_errtable[0]))
>  
> diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
> index ecb11fc9e985..81907815fda1 100644
> --- a/libfdt/libfdt.h
> +++ b/libfdt/libfdt.h
> @@ -126,7 +126,20 @@
>  	 * value. For example: a property expected to contain a string list
>  	 * is not NUL-terminated within the length of its value. */
>  
> -#define FDT_ERR_MAX		15
> +#define FDT_ERR_BADFIXUP	16
> +	/* FDT_ERR_BADFIXUP: One of the device tree overlay fixup is
> +	 * not formatted properly. */
> +
> +#define FDT_ERR_BADOVERLAY	17
> +	/* FDT_ERR_BADOVERLAY: The device tree overlay, while
> +	 * correctly structured, cannot be applied due to some
> +	 * unexpected or missing value, property or node. */
> +
> +#define FDT_ERR_NOPHANDLES	18
> +	/* FDT_ERR_NOPHANDLES: The device tree doesn't have any
> +	 * phandle available anymore without causing an overflow */
> +
> +#define FDT_ERR_MAX		18
>  
>  /**********************************************************************/
>  /* Low-level functions (you probably don't need these)                */

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]