From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Mike Looijmans <mike.looijmans-Oq418RWZeHk@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode
Date: Mon, 3 Oct 2016 16:35:08 +0200 [thread overview]
Message-ID: <20161003143508.GA26382@lunn.ch> (raw)
In-Reply-To: <1475499870-11465-1-git-send-email-mike.looijmans-Oq418RWZeHk@public.gmane.org>
> + Boolean:
> +
> + - enable-edpd : Not related to timing. Specify this property to enable
> + energy-detect power-down mode in the PHY.
The Broadcom PHYs unconditionally enable this feature.
The SMSC driver has an option: smsc,disable-energy-detect because it
seems to have a rare hardware bug when it is enabled.
And you would like to make it off by default.
Could we avoid having three drivers doing three different things?
Could you have it unconditionally on, and see if anybody reports it
being broken?
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-03 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 13:04 [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode Mike Looijmans
[not found] ` <1475499870-11465-1-git-send-email-mike.looijmans-Oq418RWZeHk@public.gmane.org>
2016-10-03 14:35 ` Andrew Lunn [this message]
2016-10-03 16:30 ` Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003143508.GA26382@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.looijmans-Oq418RWZeHk@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).