Devicetree
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"open list" <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org,
	"Gustaf Lindström" <gl@axentia.se>
Subject: Re: [PATCH v3 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding
Date: Mon, 3 Oct 2016 13:46:45 -0500	[thread overview]
Message-ID: <20161003184645.GA23584@rob-hp-laptop> (raw)
In-Reply-To: <1474928832-8766-2-git-send-email-peda@axentia.se>

On Tue, Sep 27, 2016 at 12:27:11AM +0200, Peter Rosin wrote:
> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> new file mode 100644
> index 000000000000..715ff7e332f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> @@ -0,0 +1,36 @@
> +Sharp 15" LQ150X1LG11 XGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "sharp,lq150x1lg11"
> +- power-supply: regulator to provide the VCC supply voltage (3.3 volts)

Should be named according to the input, so vcc-supply.

> +
> +Optional properties:
> +- backlight: phandle of the backlight device
> +- rlud-gpios: a single GPIO for the RL/UD (rotate 180 degrees) pin.
> +- lvds-gpios: a single GPIO for the SELLVDS pin.

Why not sellvds-gpios?

> +
> +If lrud-gpios and/or ldvs-gpios are not specified, the RL/UD and/or SELLVDS

typos...

> +pins are assumed to be handled appropriately by the hardware.
> +
> +Example:
> +
> +	backlight: backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm 0 100000>;                      /* VBR */
> +
> +		brightness-levels = <0 20 40 60 80 100>;
> +		default-brightness-level = <2>;
> +
> +		power-supply = <&vdd_12v_reg>;               /* VDD */
> +		enable-gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;  /* XSTABY */
> +	};
> +
> +	panel {
> +		compatible = "sharp,lq150x1lg11";
> +
> +		power-supply = <&vcc_3v3_reg>;               /* VCC */
> +
> +		backlight = <&backlight>;
> +		rlud-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;    /* RL/UD */
> +		lvds-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;    /* SELLVDS */
> +	};
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-10-03 18:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 22:27 [PATCH v3 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin
     [not found] ` <1474928832-8766-1-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2016-09-26 22:27   ` [PATCH v3 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding Peter Rosin
2016-10-03 18:46     ` Rob Herring [this message]
2016-10-04  4:58       ` Peter Rosin
2016-10-04 13:11         ` Rob Herring
2016-09-26 22:27 ` [PATCH v3 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161003184645.GA23584@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gl@axentia.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox