Re: [PATCH 06/14] ASoC: Add sun8i digital audio codec

Icenowy Zheng
2016-10-06T16:06:57Z

05.10.2016, 00:20, "Maxime Ripard" <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
> Hi,
>
>>  +static const struct of_device_id sun8i_codec_of_match[] = {
>>  + { .compatible = "allwinner,sun8i-a33-codec" },
>>  + { .compatible = "allwinner,sun8i-a23-codec" },
>
> I thought that the A23 and A33 had different codecs? In that case, it
> wouldn't be a good assumption to make

Yes.

>
>>  + {}
>>  +};
>>  +MODULE_DEVICE_TABLE(of, sun8i_codec_of_match);
>>  +
>>  +static struct platform_driver sun8i_codec_driver = {
>>  + .driver = {
>>  + .name = "sun8i-codec",
>>  + .owner = THIS_MODULE,
>>  + .of_match_table = sun8i_codec_of_match,
>>  + },
>>  + .probe = sun8i_codec_probe,
>>  + .remove = sun8i_codec_remove,
>>  +};
>>  +module_platform_driver(sun8i_codec_driver);
>>  +
>>  +MODULE_DESCRIPTION("Allwinner A33 (sun8i) codec driver");
>>  +MODULE_AUTHOR("huanxin<huanxin-jFKXxz0WcGyYHARAtoI1EgC/G2K4zDHf@public.gmane.org>");
>
> Those obfuscated email adresses are not really helpful :)

This kind of email addresses are kept in many places in mainline kernel.

e.g. drivers/mmc/host/sunxi-mmc.c have 'Aaron Maoye <leafy.myeh@reuuimllatech.com>'

>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> ,
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.