From: Viresh Kumar <viresh.kumar@linaro.org>
To: Markus Mayer <mmayer@broadcom.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
Device Tree List <devicetree@vger.kernel.org>,
Power Management List <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 3/3] cpufreq: brcmstb-avs-cpufreq: add debugfs support
Date: Wed, 5 Oct 2016 08:57:39 +0530 [thread overview]
Message-ID: <20161005032739.GH4664@vireshk-i7> (raw)
In-Reply-To: <1475272561-8446-4-git-send-email-mmayer@broadcom.com>
On 30-09-16, 14:56, Markus Mayer wrote:
> In order to aid debugging, we add a debugfs interface to the driver
> that allows direct interaction with the AVS co-processor.
>
> The debugfs interface provides a means for reading all and writing some
> of the mailbox registers directly from the shell prompt and enables a
> user to execute the communications protocol between ARM CPU and AVS CPU
> step-by-step.
>
> This interface should be used for debugging purposes only.
>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
> drivers/cpufreq/brcmstb-avs-cpufreq.c | 319 ++++++++++++++++++++++++++++++++++
> 1 file changed, 319 insertions(+)
I am not sure how much useful this is going to be, but I don't have
any concerns against this as well.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2016-10-05 3:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 21:55 [RESEND PATCH v2 0/3] Broadcom AVS CPUfreq driver Markus Mayer
[not found] ` <1475272561-8446-1-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-09-30 21:55 ` [RESEND PATCH v2 1/3] dt: cpufreq: brcm: New binding document for brcmstb-avs-cpufreq Markus Mayer
[not found] ` <1475272561-8446-2-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-10-05 3:27 ` Viresh Kumar
2016-09-30 21:56 ` [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs Markus Mayer
2016-10-05 3:25 ` Viresh Kumar
2016-10-05 21:04 ` Markus Mayer
[not found] ` <CAGt4E5s9UBam4RKsq3k1P77-81NR-8AeQi==7dBNnp37xxtr_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-06 4:01 ` Viresh Kumar
2016-10-06 14:51 ` Markus Mayer
2016-10-06 21:04 ` Markus Mayer
[not found] ` <20161006210459.GA19063-opzSsqMRwNylyEujtbL6/5Ym1tgvmhRUMm0uRHvK7Nw@public.gmane.org>
2016-10-07 3:41 ` Viresh Kumar
2016-10-07 3:33 ` Viresh Kumar
2016-10-03 3:29 ` [RESEND PATCH v2 0/3] Broadcom AVS CPUfreq driver Viresh Kumar
2016-09-30 21:56 ` [RESEND PATCH v2 3/3] cpufreq: brcmstb-avs-cpufreq: add debugfs support Markus Mayer
2016-10-05 3:27 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005032739.GH4664@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mmayer@broadcom.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).