From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [RESEND PATCH v2 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs Date: Fri, 7 Oct 2016 09:03:46 +0530 Message-ID: <20161007033346.GA3954@vireshk-i7> References: <1475272561-8446-1-git-send-email-mmayer@broadcom.com> <1475272561-8446-3-git-send-email-mmayer@broadcom.com> <20161005032509.GG4664@vireshk-i7> <20161006040139.GA17619@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Markus Mayer Cc: Rob Herring , Mark Rutland , "Rafael J . Wysocki" , Broadcom Kernel List , Device Tree List , Power Management List , Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org On 06-10-16, 07:51, Markus Mayer wrote: > During early development, when the driver couldn't fully register, I > would see the init() function called four times, i.e. once for each > core. If the first call succeeded, that was it. It would only get > called once. But if it failed, all cores would try to register. And I > wanted to avoid spilling the same error message four times. This is the current behavior of the cpufreq core. > I'll look at that again. It may have had something to do with how the > driver worked back then. If it doesn't happen anymore, I'll just get > rid of this code. I don't think so, but again, we don't need to have special code to save few lines which get printed only in the rare case of errors. -- viresh