From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure Date: Fri, 7 Oct 2016 10:38:53 +0200 Message-ID: <20161007083853.GH4684@lukather> References: <20161006160629.11198-1-wens@csie.org> <20161006160629.11198-3-wens@csie.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vtJ+CqYNzKB4ukR4" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20161006160629.11198-3-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --vtJ+CqYNzKB4ukR4 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote: > +struct sun4i_tcon_quirks { > + bool is_sun5i; /* sun5i has undocumented mux */ > + bool has_channel_1; /* a33 does not have channel 1 */ > + bool has_bypass_src; /* has separate input bypassing CEU */ > + bool has_dma_src; /* has DMA input */ > +}; > + I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't really relate to what we're doing there, is redundant with the compatible, and render the other quirks name useless, since we could just have is_sun.i quirks and deal with that (which is essentially what we were doing before). Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --vtJ+CqYNzKB4ukR4--