From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 4/9] drm/sun4i: Add compatible string for A31/A31s TCON (timing controller) Date: Fri, 7 Oct 2016 10:55:28 +0200 Message-ID: <20161007085528.GJ4684@lukather> References: <20161006160629.11198-1-wens@csie.org> <20161006160629.11198-5-wens@csie.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="07FIeBX8hApXX6Bi" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20161006160629.11198-5-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --07FIeBX8hApXX6Bi Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Fri, Oct 07, 2016 at 12:06:24AM +0800, Chen-Yu Tsai wrote: > The A31 TCON has mux controls for how TCON outputs are routed to the > HDMI and MIPI DSI blocks. > > Since the A31s does not have MIPI DSI, it only has a mux for the HDMI > controller input. > > This patch only adds support for the compatible strings. Actual support > for the mux controls should be added with HDMI and MIPI DSI support. Then let's add those fields then, having dead code and useless variables is never a good option :) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --07FIeBX8hApXX6Bi--