From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexandre Courbot <gnurou@gmail.com>,
devel@driverdev.osuosl.org,
devicetree <devicetree@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
JawaharBalaji Thirumalaisamy <jawaharb@juniper.net>,
linux-gpio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Debjit Ghosh <dghosh@juniper.net>,
Mohammad Kamil <mkamil@juniper.net>,
Georgi Vlaev <gvlaev@juniper.net>,
Frank Rowand <frowand.list@gmail.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 0/6] Introduce Juniper CBC FPGA
Date: Fri, 7 Oct 2016 22:37:39 +0200 [thread overview]
Message-ID: <20161007203739.GA23946@kroah.com> (raw)
In-Reply-To: <DD6D31CF-54E9-4A14-A9DD-C447D10006C9@konsulko.com>
On Fri, Oct 07, 2016 at 09:53:29PM +0300, Pantelis Antoniou wrote:
> Hi Greg,
>
> > On Oct 7, 2016, at 18:39 , Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Oct 07, 2016 at 06:20:08PM +0300, Pantelis Antoniou wrote:
> >> Add Juniper's PTX1K CBC FPGA driver. Those FPGAs
> >> are present in Juniper's PTX series of routers.
> >>
> >> The MFD driver provices a gpio device and a special
> >> driver for Juniper's board infrastucture.
> >> The FPGA infrastucture driver is providing an interface
> >> for user-space handling of the FPGA in those platforms.
> >>
> >> There are full device tree binding documents for the
> >> master mfd driver and for the slave driver.
> >>
> >> This patchset is against mainline as of today: v4.8-9431-g3477d16
> >> and is dependent on the "Juniper prerequisites" and
> >> "Juniper infrastructure" patchsets sent earlier.
> >>
> >> Georgi Vlaev (5):
> >> mfd: Add support for the PTX1K CBC FPGA
> >> gpio: Add support for PTX1K CBC FPGA spare GPIOs
> >> gpio: gpio-cbc: Document bindings of CBC FPGA GPIO block
> >> gpio: cbc-presence: Add CBC presence detect as GPIO driver
> >> gpio: gpio-cbc-presense: Document bindings of CBC FPGA presence
> >>
> >> Tom Kavanagh (1):
> >> staging: jnx: CBD-FPGA infrastructure
> >>
> >> .../bindings/gpio/jnx,gpio-cbc-presense.txt | 31 +
> >> .../devicetree/bindings/gpio/jnx,gpio-cbc.txt | 30 +
> >> drivers/gpio/Kconfig | 23 +
> >> drivers/gpio/Makefile | 2 +
> >> drivers/gpio/gpio-cbc-presence.c | 460 ++++++++++
> >> drivers/gpio/gpio-cbc.c | 236 +++++
> >> drivers/mfd/Kconfig | 16 +
> >> drivers/mfd/Makefile | 1 +
> >> drivers/mfd/cbc-core.c | 971 +++++++++++++++++++++
> >> drivers/staging/jnx/Kconfig | 34 +
> >> drivers/staging/jnx/Makefile | 5 +
> >> drivers/staging/jnx/jnx-cbc-ptx1k.c | 242 +++++
> >> drivers/staging/jnx/jnx-cbd-fpga-common.c | 332 +++++++
> >> drivers/staging/jnx/jnx-cbd-fpga-common.h | 27 +
> >> drivers/staging/jnx/jnx-cbd-fpga-core.c | 540 ++++++++++++
> >> drivers/staging/jnx/jnx-cbd-fpga-core.h | 68 ++
> >> drivers/staging/jnx/jnx-cbd-fpga-platdata.h | 51 ++
> >> drivers/staging/jnx/jnx-cbd-fpga-ptx1k.c | 134 +++
> >> drivers/staging/jnx/jnx-cbd-fpga-ptx21k.c | 143 +++
> >> drivers/staging/jnx/jnx-cbd-fpga-ptx3k.c | 111 +++
> >> drivers/staging/jnx/jnx-cbd-fpga-ptx5k.c | 107 +++
> >> include/linux/mfd/cbc-core.h | 181 ++++
> >> 22 files changed, 3745 insertions(+)
> >
> > Please don't mix driver submissions like this. Staging stuff needs to
> > go to the staging maintainer, gpio to that one, mfd to that one, and so
> > on.
> >
> > there's almost nothing anyone can do with this series as-is, sorry.
> >
> > please split it up.
> >
>
> Now I’m confused, this is a typical MFD submission:
>
> https://lwn.net/Articles/587032/
>
> Looks like it’s normal for a single patchset against multiple subsystems.
Not when it crosses the drivers/staging/ boundry.
> Do we have a definitive form for this?
Either submit all of this stuff "properly", or put it in staging, don't
cross the boundry if at all possible, it just causes a lot of confusion
and headache as the staging stuff could be deleted at any time.
You still haven't explained why you feel drivers/staging/ is the right
place for this codebase. Again, why not just submit it "properly"?
thanks,
greg k-h
prev parent reply other threads:[~2016-10-07 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 15:20 [PATCH 0/6] Introduce Juniper CBC FPGA Pantelis Antoniou
2016-10-07 15:20 ` [PATCH 1/6] mfd: Add support for the PTX1K " Pantelis Antoniou
2016-10-07 15:20 ` [PATCH 2/6] gpio: Add support for PTX1K CBC FPGA spare GPIOs Pantelis Antoniou
2016-10-21 8:44 ` Linus Walleij
2016-10-07 15:20 ` [PATCH 3/6] gpio: gpio-cbc: Document bindings of CBC FPGA GPIO block Pantelis Antoniou
2016-10-21 8:45 ` Linus Walleij
2016-10-07 15:20 ` [PATCH 4/6] gpio: cbc-presence: Add CBC presence detect as GPIO driver Pantelis Antoniou
2016-10-21 8:49 ` Linus Walleij
2016-10-07 15:20 ` [PATCH 5/6] gpio: gpio-cbc-presense: Document bindings of CBC FPGA presence Pantelis Antoniou
2016-10-07 15:20 ` [PATCH 6/6] staging: jnx: CBD-FPGA infrastructure Pantelis Antoniou
2016-10-07 15:39 ` [PATCH 0/6] Introduce Juniper CBC FPGA Greg Kroah-Hartman
[not found] ` <20161007153944.GA13519-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-10-07 15:44 ` Pantelis Antoniou
2016-10-07 18:53 ` Pantelis Antoniou
2016-10-07 20:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007203739.GA23946@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dghosh@juniper.net \
--cc=frowand.list@gmail.com \
--cc=gnurou@gmail.com \
--cc=gvlaev@juniper.net \
--cc=jawaharb@juniper.net \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mkamil@juniper.net \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).