From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
linux@armlinux.org.uk, davem@davemloft.net, f.fainelli@gmail.com,
andrew@lunn.ch, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module
Date: Mon, 10 Oct 2016 14:31:51 +0200 [thread overview]
Message-ID: <20161010123151.GI3462@lukather> (raw)
In-Reply-To: <1475828757-926-5-git-send-email-clabbe.montjoie@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
Hi,
On Fri, Oct 07, 2016 at 10:25:51AM +0200, Corentin Labbe wrote:
> This patch add the dt node for the syscon register present on the
> Allwinner H3.
>
> Only two register are present in this syscon and the only one useful is
> the one dedicated to EMAC clock.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 8a95e36..1101d2f 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -140,6 +140,11 @@
> #size-cells = <1>;
> ranges;
>
> + syscon: syscon@01c00000 {
> + compatible = "syscon";
It would be great to have a more specific compatible here in addition
to the syscon, like "allwinner,sun8i-h3-system-controller".
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-10 12:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 8:25 [PATCH v4 00/10] net-next: ethernet: add sun8i-emac driver Corentin Labbe
[not found] ` <1475828757-926-1-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-07 8:25 ` [PATCH v4 01/10] " Corentin Labbe
2016-10-07 15:02 ` Joe Perches
2016-10-23 8:55 ` LABBE Corentin
[not found] ` <1475828757-926-2-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-23 12:08 ` Rami Rosen
2016-10-07 8:25 ` [PATCH v4 02/10] MAINTAINERS: Add myself as maintainer of sun8i-emac Corentin Labbe
2016-10-07 8:25 ` [PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Corentin Labbe
2016-10-10 12:30 ` Maxime Ripard
2016-10-10 15:15 ` Rob Herring
2016-10-10 15:13 ` Rob Herring
2016-10-13 13:39 ` LABBE Corentin
2016-10-07 8:25 ` [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module Corentin Labbe
2016-10-10 12:31 ` Maxime Ripard [this message]
2016-10-10 12:50 ` Jean-Francois Moine
2016-10-11 9:39 ` Maxime Ripard
2016-10-07 8:25 ` [PATCH v4 05/10] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver Corentin Labbe
2016-10-07 8:25 ` [PATCH v4 06/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC Corentin Labbe
2016-10-07 8:25 ` [PATCH v4 07/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI One Corentin Labbe
2016-10-07 8:25 ` [PATCH v4 08/10] ARM: dts: sun8i: Enable sun8i-emac on the Orange Pi 2 Corentin Labbe
2016-10-12 8:55 ` Jean-Francois Moine
[not found] ` <20161012105559.aaf9122e376fa5969a2e61d9-GANU6spQydw@public.gmane.org>
2016-10-12 9:03 ` Maxime Ripard
2016-10-07 8:25 ` [PATCH v4 09/10] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig Corentin Labbe
2016-10-07 8:25 ` [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig Corentin Labbe
2016-10-10 12:30 ` Maxime Ripard
2016-10-10 12:35 ` LABBE Corentin
2016-10-10 13:09 ` Jean-Francois Moine
2016-10-11 9:40 ` Maxime Ripard
2016-10-12 8:36 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010123151.GI3462@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).