From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure Date: Tue, 11 Oct 2016 11:36:59 +0200 Message-ID: <20161011093659.GQ3462@lukather> References: <20161006160629.11198-1-wens@csie.org> <20161006160629.11198-3-wens@csie.org> <20161007083853.GH4684@lukather> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PkEWctFf+8E2rcii" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel , linux-arm-kernel , linux-kernel , devicetree , linux-sunxi List-Id: devicetree@vger.kernel.org --PkEWctFf+8E2rcii Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Tue, Oct 11, 2016 at 05:16:21PM +0800, Chen-Yu Tsai wrote: > On Fri, Oct 7, 2016 at 4:38 PM, Maxime Ripard > wrote: > > Hi, > > > > On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote: > >> +struct sun4i_tcon_quirks { > >> + bool is_sun5i; /* sun5i has undocumented mux */ > >> + bool has_channel_1; /* a33 does not have channel 1 */ > >> + bool has_bypass_src; /* has separate input bypassing CEU */ > >> + bool has_dma_src; /* has DMA input */ > >> +}; > >> + > > > > I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't > > really relate to what we're doing there, is redundant with the > > compatible, and render the other quirks name useless, since we could > > just have is_sun.i quirks and deal with that (which is essentially > > what we were doing before). > > Lets call it has_unknown_mux then. has_mux would be confusing with > the HDMI and MIPI DSI muxes on sun6i. That works for me. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --PkEWctFf+8E2rcii--