From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/5] Input: add driver for Ilitek ili2139 touch IC Date: Tue, 11 Oct 2016 11:51:14 -0700 Message-ID: <20161011185114.GB8841@dtor-ws> References: <20161011003359.26079-1-icenowy@aosc.xyz> <20161011003359.26079-3-icenowy@aosc.xyz> <20161011174046.GA27925@dtor-ws> <220181476210841@web5j.yandex.ru> Reply-To: dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <220181476210841-OHkeJ68Zrv9uio3avFS2gg@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Hans de Goede , Henrik Rydberg , Mark Rutland , Russell King , Thierry Reding , Shawn Guo , Jarkko Sakkinen , Marek Vasut , Rask Ingemann Lambertsen , Greg Kroah-Hartman , Geert Uytterhoeven , Andrew Morton , Michael Welling , Arnd Bergmann , Markus Pargmann , Damien Riegel , Benjamin Tissoires , Jeffrey Lin , Javier List-Id: devicetree@vger.kernel.org On Wed, Oct 12, 2016 at 02:34:01AM +0800, Icenowy Zheng wrote: >=20 >=20 > 12.10.2016, 01:40, "Dmitry Torokhov" : > > Hi Icenowy, > > > > On Tue, Oct 11, 2016 at 08:33:57AM +0800, Icenowy Zheng wrote: > >> =C2=A0This driver adds support for Ilitek ili2139 touch IC, which is u= sed in > >> =C2=A0several Colorfly tablets (for example, Colorfly E708 Q1, which i= s an > >> =C2=A0Allwinner A31s tablet with mainline kernel support). > >> > >> =C2=A0Theortically it may support more Ilitek touch ICs, however, only= ili2139 > >> =C2=A0is used in any mainlined device. > >> > >> =C2=A0It supports device tree enumeration, with screen resolution and = axis > >> =C2=A0quirks configurable. > >> > >> =C2=A0Signed-off-by: Icenowy Zheng > > > > Please extend ili210x.c instead of adding brand new driver, they look > > very similar. > > > > Thanks. >=20 > The driver is too old, lack of maintaince and needs some platform data ha= cks. > (At least makes it not capable to be used on current ARM devices, as they= 're > described with device tree) There are many drivers that can do both platform and dt-setup. >=20 > Maybe I will rename the new driver modified by me to ili210x, add support= for > the old protocol (but I have no chips to test it), and drop the old ili21= 0x. > (This driver is capable of dt probing, and uses devm_ functions) You can add "racy on removal" to the list (you need to take care your work is canceled at right times, and canceling it before interrupt is freed is not the right time as interrupt might fire and the work get scheduled again). Also I think your driver is essentially working in polling mode because you always reschedule the delayed work. No, like I said, please work with existing driver, adding DT support and support for the newer version of the protocol. Thanks. --=20 Dmitry --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.