From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Markus Mayer <mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: "Rafael J . Wysocki"
<rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Broadcom Kernel List
<bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Device Tree List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Power Management List
<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs
Date: Wed, 12 Oct 2016 11:08:42 +0530 [thread overview]
Message-ID: <20161012053842.GF19385@vireshk-i7> (raw)
In-Reply-To: <1475882487-2155-3-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
On 07-10-16, 16:21, Markus Mayer wrote:
> +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy)
> +{
> + struct private_data *priv = policy->driver_data;
> +
> + iounmap(priv->base);
> + iounmap(priv->avs_intr_base);
> +
> + return 0;
> +}
Shouldn't the above be done in the below routine instead ?
> +static int brcm_avs_cpufreq_remove(struct platform_device *pdev)
> +{
> + platform_set_drvdata(pdev, NULL);
> +
> + return cpufreq_unregister_driver(&brcm_avs_driver);
> +}
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-12 5:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 23:21 [PATCH v3 0/3] Broadcom STB AVS CPUfreq driver Markus Mayer
[not found] ` <1475882487-2155-1-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-10-07 23:21 ` [PATCH v3 1/3] dt: cpufreq: brcm: New binding document for brcmstb-avs-cpufreq Markus Mayer
2016-10-07 23:21 ` [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs Markus Mayer
[not found] ` <1475882487-2155-3-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-10-12 5:38 ` Viresh Kumar [this message]
2016-10-12 16:08 ` Markus Mayer
2016-10-07 23:21 ` [PATCH v3 3/3] cpufreq: brcmstb-avs-cpufreq: add debugfs support Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012053842.GF19385@vireshk-i7 \
--to=viresh.kumar-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).