From: Christoph Hellwig <hch@infradead.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: devicetree@vger.kernel.org, Joao.Pinto@synopsys.com,
Arnd Bergmann <arnd@arndb.de>,
linux-doc@vger.kernel.org, Joao Pinto <jpinto@synopsys.com>,
Jingoo Han <jingoohan1@gmail.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
nsekhar@ti.com, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
hch@infradead.org, m-karicheri2@ti.com,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-omap@vger.kernel.org, mingkai.hu@nxp.com
Subject: Re: [RFC PATCH 02/11] pci: endpoint: introduce configfs entry for configuring EP functions
Date: Wed, 12 Oct 2016 05:42:10 -0700 [thread overview]
Message-ID: <20161012124210.GB942@infradead.org> (raw)
In-Reply-To: <1473829927-20466-3-git-send-email-kishon@ti.com>
On Wed, Sep 14, 2016 at 10:41:58AM +0530, Kishon Vijay Abraham I wrote:
> diff --git a/drivers/pci/endpoint/Kconfig b/drivers/pci/endpoint/Kconfig
> index a6d827c..f1dd206 100644
> --- a/drivers/pci/endpoint/Kconfig
> +++ b/drivers/pci/endpoint/Kconfig
> @@ -13,7 +13,9 @@ config PCI_ENDPOINT
>
> Enabling this option will build the endpoint library, which
> includes endpoint controller library and endpoint function
> - library.
> + library. This will also enable the configfs entry required to
> + configure the endpoint function and used to bind the
> + function with a endpoint controller.
>
> If in doubt, say "N" to disable Endpoint support.
This needs to grow a
depends on CONFIGFS_FS
> +/**
> + * pci-ep-cfs.c - configfs to configure the PCI endpoint
Please don't use the file name in the top of the file comment, it's
only bound to get out of date..
> +struct pci_epf_info {
> + struct config_item pci_epf;
> + struct pci_epf *epf;
> +};
Any reason not to simply embedd the config_item into the pci_epf structure?
next prev parent reply other threads:[~2016-10-12 12:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 5:11 [RFC PATCH 00/11] pci: support for configurable PCI endpoint Kishon Vijay Abraham I
2016-09-14 5:11 ` [RFC PATCH 01/11] pci: endpoint: add EP core layer to enable EP controller and EP functions Kishon Vijay Abraham I
2016-10-12 12:38 ` Christoph Hellwig
2016-09-14 5:11 ` [RFC PATCH 03/11] Documentation: PCI: guide to use PCI Endpoint Core Layer Kishon Vijay Abraham I
2016-09-14 5:12 ` [RFC PATCH 04/11] pci: endpoint: functions: add an EP function to test PCI Kishon Vijay Abraham I
2016-09-14 5:12 ` [RFC PATCH 05/11] pci: rename *host* directory to *controller* Kishon Vijay Abraham I
2016-10-12 12:43 ` Christoph Hellwig
2016-09-14 5:12 ` [RFC PATCH 06/11] pci: controller: split designware into *core* and *host* Kishon Vijay Abraham I
2016-09-14 5:12 ` [RFC PATCH 07/11] pci: controller: designware: Add EP mode support Kishon Vijay Abraham I
2016-09-23 14:41 ` Rob Herring
2016-09-27 11:28 ` Kishon Vijay Abraham I
2016-09-14 5:12 ` [RFC PATCH 08/11] pci: controller: dra7xx: " Kishon Vijay Abraham I
2016-09-23 14:52 ` Rob Herring
2016-09-27 11:34 ` Kishon Vijay Abraham I
2016-09-14 5:12 ` [RFC PATCH 09/11] misc: add a new host side PCI endpoint test driver Kishon Vijay Abraham I
[not found] ` <1473829927-20466-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2016-09-14 5:11 ` [RFC PATCH 02/11] pci: endpoint: introduce configfs entry for configuring EP functions Kishon Vijay Abraham I
2016-10-12 12:42 ` Christoph Hellwig [this message]
2016-09-14 5:12 ` [RFC PATCH 10/11] ARM: dts: DRA7: Modify pcie1 dt node for EP mode Kishon Vijay Abraham I
2016-09-14 5:12 ` [RFC PATCH 11/11] HACK: pci: controller: dra7xx: disable smart idle Kishon Vijay Abraham I
2016-09-14 13:25 ` [RFC PATCH 00/11] pci: support for configurable PCI endpoint Arnd Bergmann
2016-09-15 8:33 ` Kishon Vijay Abraham I
2016-09-22 13:34 ` Arnd Bergmann
2016-09-26 6:08 ` Kishon Vijay Abraham I
[not found] ` <57E8BB69.4020804-l0cyMroinI0@public.gmane.org>
2016-09-29 8:31 ` Kishon Vijay Abraham I
2016-10-12 12:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012124210.GB942@infradead.org \
--to=hch@infradead.org \
--cc=Joao.Pinto@synopsys.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jingoohan1@gmail.com \
--cc=jpinto@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mingkai.hu@nxp.com \
--cc=nsekhar@ti.com \
--cc=pratyush.anand@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).