Re: [PATCH v7 0/4] libfdt: Add support for device tree overlays

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2633 bytes --]

On Wed, Oct 12, 2016 at 05:06:07PM +0200, Pantelis Antoniou wrote:
> Hi Phil,
> 
> > On Oct 6, 2016, at 23:16 , Phil Elwell <philip.j.elwell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > 
> > On 06/10/2016 10:47, David Gibson wrote:
> >> On Fri, Sep 30, 2016 at 03:57:13PM +0200, Maxime Ripard wrote:
> >>> Hi,
> >>> 
> >>> The device tree overlays are a great solution to the issue raised by
> >>> the bunch expandable boards we find everywhere these days, like the
> >>> Beaglebone, Raspberry Pi or CHIP.
> >>> 
> >>> Although for now Linux is the only available tool that can deal with
> >>> overlays, some other components like bootloaders or user-space tools
> >>> might need to apply these overlays on top of a base device tree.
> >>> 
> >>> To address these use cases, we introduce a new function to the libfdt,
> >>> fdt_overlay_apply, that does just that.
> >>> 
> >>> You can find a test program here: http://code.bulix.org/792zum-99476?raw
> >>> 
> >>> This is the last patches sent to U-boot, with the modifications
> >>> suggested by David, and the additional test cases.
> >>> 
> >>> Let me know what you think!
> >>> Maxime
> >> Looking pretty good.  There's a minor error in 3/4 which I've pointed
> >> out, it can be fixed in a followup.
> >> 
> >> An error in the conditionals means it's trying to run some of the
> >> tests which require an overlay-aware dtc on even when that's not
> >> available - I adjusted 4/4 to correct that.
> >> 
> >> It also hit build failures on Travis, because the compiler version
> >> there complains about local variables named 'index' shadowing the
> >> standard library function.  I've corrected that with a followup patch.
> >> 
> >> With that done, the whole lot has been committed to master.
> >> 
> > Now that upstream libfdt can resolve and apply overlays we need a way
> > of generating them. I have a set of three patches from Pantelis that
> > add "plugin" support to dtc, together with two downstream (Raspberry Pi)
> > patches that fix an uninitialised memory reference and restrict
> > __local_fixups__  generation to overlays.
> > 
> > Is there already a plan to get the enhanced dtc upstreamed? If so, can I
> > get the downstream fixes included?
> > 
> 
> David, my patchset is kept updated against mainline dtc.
> What are the remaining stumbling blocks in getting in accepted?

Well, repost it and we'll see.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]