[PATCH v2 2/3] ASoC: cs35l34: Add device tree bindings file for cs35l34

[PATCH v2 2/3] ASoC: cs35l34: Add device tree bindings file for cs35l34

[Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA]

From: Paul Handrigan <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>

Add device tree bindings file for the cs35l34 8V boosted
class D amplifier.

Signed-off-by: Paul Handrigan <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
---
 .../devicetree/bindings/sound/cs35l34.txt          | 64 ++++++++++++++++++++++
 1 file changed, 64 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/cs35l34.txt

diff --git a/Documentation/devicetree/bindings/sound/cs35l34.txt b/Documentation/devicetree/bindings/sound/cs35l34.txt
new file mode 100644
index 0000000..b218ead
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/cs35l34.txt
@@ -0,0 +1,64 @@
+CS35L34 Speaker Amplifier
+
+Required properties:
+
+  - compatible : "cirrus,cs35l34"
+
+  - reg : the I2C address of the device for I2C.
+
+  - VA-supply, VP-supply : power supplies for the device,
+    as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt.
+
+  - cirrus,boost-vtge-millivolt : Boost Voltage Value.  Configures the boost
+    converter's output voltage in mV. The range is from VP to 8V with
+    increments of 100mV.
+
+  - cirrus,boost-nanohenry: Inductor value for boost converter. The value is
+    in nH and they can be values of 1000nH, 1100nH, 1200nH, 1500nH, and 2200nH.
+
+Optional properties:
+
+  - reset-gpios: GPIO used to reset the amplifier.
+
+  - interrupt-parent : Specifies the phandle of the interrupt controller to
+    which the IRQs from CS35L34 are delivered to.
+  - interrupts : IRQ line info CS35L34.
+    (See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
+    for further information relating to interrupt properties)
+
+  - cirrus,boost-peak-milliamp : Boost converter peak current limit in mA. The
+    range starts at 1200mA and goes to a maximum of 3840mA with increments of
+    80mA. The default value is 2480mA.
+
+  - cirrus,i2s-sdinloc : ADSP SDIN I2S channel location. Indicates whether the
+    received mono data is in the left or right portion of the I2S frame
+    according to the AD0 pin or directly via this configuration.
+    0x0 (Default) = Selected by AD0 input (if AD0 = LOW, use left channel),
+    0x2 = Left,
+    0x1 = Selected by the inversion of the AD0 input (if AD0 = LOW, use right
+    channel),
+    0x3 = Right.
+
+  - cirrus,gain-zc-disable: Boolean property. If set, the gain change will take
+    effect without waiting for a zero cross.
+
+  - cirrus,tdm-rising-edge: Boolean property. If set, data is on the rising edge of
+    SCLK. Otherwise, data is on the falling edge of SCLK.
+
+
+Example:
+
+cs35l34: cs35l34@40 {
+	compatible = "cirrus,cs35l34";
+	reg = <0x40>;
+
+	interrupt-parent = <&gpio8>;
+	interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+	reset-gpios = <&gpio 10 0>;
+
+	cirrus,boost-vtge-milltvolt = <8000>; /* 8V */
+	cirrus,boost-ind-nanohenry = <1000>; /* 1uH */
+	cirrus,boost-peak-milliamp = <3000>; /* 3A */
+};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/3] dt/bindings: Add milivolt, milliamps, and nanohenry units

[Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA]

From: Paul Handrigan <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>

Add millivolt, milliamp, and nanohenry units to the Electricity
category.

Signed-off-by: Paul Handrigan <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
---
 Documentation/devicetree/bindings/property-units.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt
index 12278d7..92d6793 100644
--- a/Documentation/devicetree/bindings/property-units.txt
+++ b/Documentation/devicetree/bindings/property-units.txt
@@ -25,9 +25,12 @@ Distance
 Electricity
 ----------------------------------------
 -microamp	: micro amps
+-milliamp	: milli amps
 -ohms		: Ohms
 -micro-ohms	: micro Ohms
 -microvolt	: micro volts
+-millivolt	: micro volts
+-nanohenry	: nano henries
 
 Temperature
 ----------------------------------------
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Applied "ASoC: cs35l34: Add device tree bindings file for cs35l34" to the asoc tree

[Mark Brown]

The patch

   ASoC: cs35l34: Add device tree bindings file for cs35l34

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 41f8bf322da58162f67d9a9119fd3c86ff8cee2f Mon Sep 17 00:00:00 2001
From: Paul Handrigan <Paul.Handrigan@cirrus.com>
Date: Wed, 12 Oct 2016 13:53:29 -0500
Subject: [PATCH] ASoC: cs35l34: Add device tree bindings file for cs35l34

Add device tree bindings file for the cs35l34 8V boosted
class D amplifier.

Signed-off-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 .../devicetree/bindings/sound/cs35l34.txt          | 64 ++++++++++++++++++++++
 1 file changed, 64 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/cs35l34.txt

diff --git a/Documentation/devicetree/bindings/sound/cs35l34.txt b/Documentation/devicetree/bindings/sound/cs35l34.txt
new file mode 100644
index 000000000000..b218ead2e68e
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/cs35l34.txt
@@ -0,0 +1,64 @@
+CS35L34 Speaker Amplifier
+
+Required properties:
+
+  - compatible : "cirrus,cs35l34"
+
+  - reg : the I2C address of the device for I2C.
+
+  - VA-supply, VP-supply : power supplies for the device,
+    as covered in
+    Documentation/devicetree/bindings/regulator/regulator.txt.
+
+  - cirrus,boost-vtge-millivolt : Boost Voltage Value.  Configures the boost
+    converter's output voltage in mV. The range is from VP to 8V with
+    increments of 100mV.
+
+  - cirrus,boost-nanohenry: Inductor value for boost converter. The value is
+    in nH and they can be values of 1000nH, 1100nH, 1200nH, 1500nH, and 2200nH.
+
+Optional properties:
+
+  - reset-gpios: GPIO used to reset the amplifier.
+
+  - interrupt-parent : Specifies the phandle of the interrupt controller to
+    which the IRQs from CS35L34 are delivered to.
+  - interrupts : IRQ line info CS35L34.
+    (See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
+    for further information relating to interrupt properties)
+
+  - cirrus,boost-peak-milliamp : Boost converter peak current limit in mA. The
+    range starts at 1200mA and goes to a maximum of 3840mA with increments of
+    80mA. The default value is 2480mA.
+
+  - cirrus,i2s-sdinloc : ADSP SDIN I2S channel location. Indicates whether the
+    received mono data is in the left or right portion of the I2S frame
+    according to the AD0 pin or directly via this configuration.
+    0x0 (Default) = Selected by AD0 input (if AD0 = LOW, use left channel),
+    0x2 = Left,
+    0x1 = Selected by the inversion of the AD0 input (if AD0 = LOW, use right
+    channel),
+    0x3 = Right.
+
+  - cirrus,gain-zc-disable: Boolean property. If set, the gain change will take
+    effect without waiting for a zero cross.
+
+  - cirrus,tdm-rising-edge: Boolean property. If set, data is on the rising edge of
+    SCLK. Otherwise, data is on the falling edge of SCLK.
+
+
+Example:
+
+cs35l34: cs35l34@40 {
+	compatible = "cirrus,cs35l34";
+	reg = <0x40>;
+
+	interrupt-parent = <&gpio8>;
+	interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+	reset-gpios = <&gpio 10 0>;
+
+	cirrus,boost-vtge-milltvolt = <8000>; /* 8V */
+	cirrus,boost-ind-nanohenry = <1000>; /* 1uH */
+	cirrus,boost-peak-milliamp = <3000>; /* 3A */
+};
-- 
2.9.3

Re: [alsa-devel] [PATCH v2 3/3] dt/bindings: Add milivolt, milliamps, and nanohenry units

[Charles Keepax]

On Wed, Oct 12, 2016 at 01:53:30PM -0500, Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org wrote:
> From: Paul Handrigan <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
> 
> Add millivolt, milliamp, and nanohenry units to the Electricity
> category.
> 
> Signed-off-by: Paul Handrigan <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/property-units.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt
> index 12278d7..92d6793 100644
> --- a/Documentation/devicetree/bindings/property-units.txt
> +++ b/Documentation/devicetree/bindings/property-units.txt
> @@ -25,9 +25,12 @@ Distance
>  Electricity
>  ----------------------------------------
>  -microamp	: micro amps
> +-milliamp	: milli amps
>  -ohms		: Ohms
>  -micro-ohms	: micro Ohms
>  -microvolt	: micro volts
> +-millivolt	: micro volts
Typo here         ^^^^^

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] dt/bindings: Add milivolt, milliamps, and nanohenry units

[Rob Herring]

On Wed, Oct 12, 2016 at 1:53 PM,  <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org> wrote:
> From: Paul Handrigan <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
>
> Add millivolt, milliamp, and nanohenry units to the Electricity
> category.
>
> Signed-off-by: Paul Handrigan <Paul.Handrigan-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/property-units.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt
> index 12278d7..92d6793 100644
> --- a/Documentation/devicetree/bindings/property-units.txt
> +++ b/Documentation/devicetree/bindings/property-units.txt
> @@ -25,9 +25,12 @@ Distance
>  Electricity
>  ----------------------------------------
>  -microamp      : micro amps
> +-milliamp      : milli amps

Please explain why you need need this. Is 2^32 uA not enough range for
you? While we do have multiple units for some, that's because people
picked arbitrary units for their properties before this doc existed.
Ideally, we only have 1 unit to prevent that problem.

>  -ohms          : Ohms
>  -micro-ohms    : micro Ohms
>  -microvolt     : micro volts
> +-millivolt     : micro volts

Same question.

> +-nanohenry     : nano henries
>
>  Temperature
>  ----------------------------------------
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] dt/bindings: Add milivolt, milliamps, and nanohenry units

[Handrigan, Paul]

>>  Electricity
>>  ----------------------------------------
>>  -microamp      : micro amps
>> +-milliamp      : milli amps
>
>Please explain why you need need this. Is 2^32 uA not enough range for
>you? While we do have multiple units for some, that's because people
>picked arbitrary units for their properties before this doc existed.
>Ideally, we only have 1 unit to prevent that problem.

2^32 would be enough, however, microamps would not be a good
representation for
this particular entry. For example, if the current limit is 2.1A the
entry will have to be 2100000.  Micro amps will not be the best
representation for this value from a scientific notation perspective.
Since the scale is in miiliamps as it is defined in the data sheet of
this device, it will be best to stay consistent since an error in
conversion
could cause serious problems.

Also, I really don¹t see why adding milliamps and millivolts as being a
major
problems since both of them are commonly used.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] dt/bindings: Add milivolt, milliamps, and nanohenry units

[Rob Herring]

On Tue, Oct 18, 2016 at 12:43:48AM +0000, Handrigan, Paul wrote:
> 
> 
> 
> >>  Electricity
> >>  ----------------------------------------
> >>  -microamp      : micro amps
> >> +-milliamp      : milli amps
> >
> >Please explain why you need need this. Is 2^32 uA not enough range for
> >you? While we do have multiple units for some, that's because people
> >picked arbitrary units for their properties before this doc existed.
> >Ideally, we only have 1 unit to prevent that problem.
> 
> 2^32 would be enough, however, microamps would not be a good
> representation for
> this particular entry. For example, if the current limit is 2.1A the
> entry will have to be 2100000.  Micro amps will not be the best
> representation for this value from a scientific notation perspective.
> Since the scale is in miiliamps as it is defined in the data sheet of
> this device, it will be best to stay consistent since an error in
> conversion
> could cause serious problems.
> 
> Also, I really don¹t see why adding milliamps and millivolts as being a
> major
> problems since both of them are commonly used.

As I explained, we want to have some uniformity in properties especially 
across different bindings. That's not something I want to check in every
review. Telling people to add units is enough.

I don't see how adding '000' is a problem.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] dt/bindings: Add milivolt, milliamps, and nanohenry units

[Brian Austin]

[-- Attachment #1: Type: text/plain, Size: 1873 bytes --]

On Tue, 18 Oct 2016, Rob Herring wrote:

> On Tue, Oct 18, 2016 at 12:43:48AM +0000, Handrigan, Paul wrote:
> > 
> > 
> > 
> > >>  Electricity
> > >>  ----------------------------------------
> > >>  -microamp      : micro amps
> > >> +-milliamp      : milli amps
> > >
> > >Please explain why you need need this. Is 2^32 uA not enough range for
> > >you? While we do have multiple units for some, that's because people
> > >picked arbitrary units for their properties before this doc existed.
> > >Ideally, we only have 1 unit to prevent that problem.
> > 
> > 2^32 would be enough, however, microamps would not be a good
> > representation for
> > this particular entry. For example, if the current limit is 2.1A the
> > entry will have to be 2100000.  Micro amps will not be the best
> > representation for this value from a scientific notation perspective.
> > Since the scale is in miiliamps as it is defined in the data sheet of
> > this device, it will be best to stay consistent since an error in
> > conversion
> > could cause serious problems.
> > 
> > Also, I really don¹t see why adding milliamps and millivolts as being a
> > major
> > problems since both of them are commonly used.
> 
> As I explained, we want to have some uniformity in properties especially 
> across different bindings. That's not something I want to check in every
> review. Telling people to add units is enough.
> 
> I don't see how adding '000' is a problem.
> 
> Rob
> 
Why is it such a big deal to not have a representation for all the common 
units of measurement? They are already defined so why not add them to your 
suffix file? I would think that if you are going to make us use this 
suffix devicetree thing, you would not restrict us to use only the units 
you think are appropriate.

I wouldn't think you would restrict us to saying it is a 5700ml Hemi V8 
would you?


Brian

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]