From: Andrew Lunn <andrew@lunn.ch>
To: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
f.fainelli@gmail.com, Allan.Nielsen@microsemi.com
Subject: Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.
Date: Fri, 14 Oct 2016 14:02:28 +0200 [thread overview]
Message-ID: <20161014120228.GF5822@lunn.ch> (raw)
In-Reply-To: <1476445233-26524-3-git-send-email-Raju.Lakkaraju@microsemi.com>
> On Fri, Oct 14, 2016 at 05:10:33PM +0530, Raju Lakkaraju wrote:
> From: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
>
> VSC8531 Fast Link Failure 2 feature enables the PHY to indicate the
> onset of a potential link failure in < 100 usec for 100BASE-TX
> operation. FLF2 is supported through the MDINT (active low) pin.
Is the MDINT pin specific to this feature, or a general interrupt pin?
Device tree is used to describe the hardware. It should not really
describe software or configuration. But the borders are a bit
fluffly. Signal edge rates is near to hardware. This is a lot more
towards configuration. So i'm not sure a device tree property is the
correct way to describe this.
This is also a feature i know other PHYs support. The Marvell PHY has
a "Metro Ethernet" extension which allows it to report link failures
for 1000BASE-T in 10, 20 or 40ms, instead of the usual 750ms. So we
need a generic solution other PHYs can implement.
As with cable testing, i think it should be an ethtool option.
Andrew
next prev parent reply other threads:[~2016-10-14 12:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 11:40 [PATCH net-next 0/2] net: phy: Add Downshift, FLF2 drivers for Microsemi Raju Lakkaraju
[not found] ` <1476445233-26524-1-git-send-email-Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-14 11:40 ` [PATCH net-next 1/2] net: phy: Add Speed downshift set driver for Microsemi PHYs Raju Lakkaraju
2016-10-14 12:12 ` Andrew Lunn
2016-10-17 7:31 ` Raju Lakkaraju
2016-10-17 12:38 ` Florian Fainelli
2016-10-18 10:41 ` Raju Lakkaraju
[not found] ` <1476445233-26524-2-git-send-email-Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-18 14:24 ` Rob Herring
2016-10-14 11:40 ` [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 " Raju Lakkaraju
2016-10-14 12:02 ` Andrew Lunn [this message]
2016-10-17 8:13 ` Raju Lakkaraju
[not found] ` <20161017081312.GB2365-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-17 12:51 ` Florian Fainelli
[not found] ` <838C6202-9B7D-4AFA-B163-55515044FA4F-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-18 10:34 ` Raju Lakkaraju
[not found] ` <20161018103413.GA31087-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-18 10:58 ` Andrew Lunn
2016-10-18 11:31 ` Raju Lakkaraju
[not found] ` <20161018113043.GA19357-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-18 11:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014120228.GF5822@lunn.ch \
--to=andrew@lunn.ch \
--cc=Allan.Nielsen@microsemi.com \
--cc=Raju.Lakkaraju@microsemi.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).