From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Raju Lakkaraju <Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
Cc: Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Allan.Nielsen-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org
Subject: Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.
Date: Tue, 18 Oct 2016 12:58:20 +0200 [thread overview]
Message-ID: <20161018105820.GM26778@lunn.ch> (raw)
In-Reply-To: <20161018103413.GA31087-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
> > In fact, this looks a lot like netdev features (e.g: checksum
> > offload), and there seems to be some commonality here between at
> > least Marvell and Microsemi (for the faster link down reporting),
> > so maybe we should start adding PHY features similar to netdev
> > features?
> Sure.
>
> I would like add one flag in phy_device structure:
> u64 phy_features;
>
> In phy_driver structure, i would like to add 2 function pointer as
>
> int (*phy_featues_set)(struct phy_device *phydev);
> int (*phy_featues_get)(struct phy_device *phydev);
>
> All the PHY specific features i.e. Fast link failure -2, Downshift, Loopback etc
> are the case in feature_set/feature_get functions.
Please follow how the ethertool features are implemented. So you need
to extend net/core/ethtool.c to pass these call down, etc.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-18 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 11:40 [PATCH net-next 0/2] net: phy: Add Downshift, FLF2 drivers for Microsemi Raju Lakkaraju
[not found] ` <1476445233-26524-1-git-send-email-Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-14 11:40 ` [PATCH net-next 1/2] net: phy: Add Speed downshift set driver for Microsemi PHYs Raju Lakkaraju
2016-10-14 12:12 ` Andrew Lunn
2016-10-17 7:31 ` Raju Lakkaraju
2016-10-17 12:38 ` Florian Fainelli
2016-10-18 10:41 ` Raju Lakkaraju
[not found] ` <1476445233-26524-2-git-send-email-Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-18 14:24 ` Rob Herring
2016-10-14 11:40 ` [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 " Raju Lakkaraju
2016-10-14 12:02 ` Andrew Lunn
2016-10-17 8:13 ` Raju Lakkaraju
[not found] ` <20161017081312.GB2365-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-17 12:51 ` Florian Fainelli
[not found] ` <838C6202-9B7D-4AFA-B163-55515044FA4F-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-18 10:34 ` Raju Lakkaraju
[not found] ` <20161018103413.GA31087-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-18 10:58 ` Andrew Lunn [this message]
2016-10-18 11:31 ` Raju Lakkaraju
[not found] ` <20161018113043.GA19357-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>
2016-10-18 11:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018105820.GM26778@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=Allan.Nielsen-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org \
--cc=Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).