Devicetree
 help / color / mirror / Atom feed
From: Peter Griffin <peter.griffin@linaro.org>
To: Kieran Bingham <kieran@ksquared.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	jan.kiszka@siemens.com, lee.jones@linaro.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] scripts/gdb: fixup some pep8 errors in proc.py
Date: Tue, 18 Oct 2016 16:57:57 +0100	[thread overview]
Message-ID: <20161018155757.GA24274@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <477b66cc-05dc-57fa-38fb-f80510935c2e@bingham.xyz>

Hi Kieran,

On Tue, 18 Oct 2016, Kieran Bingham wrote:

> Hi Pete,
> 
> On 18/10/16 16:07, Peter Griffin wrote:
> > proc.py:22:1: E302 expected 2 blank lines, found 1
> > proc.py:200:1: E302 expected 2 blank lines, found 1
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> >  scripts/gdb/linux/proc.py | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> > index f20fcfa..2d6f74e 100644
> > --- a/scripts/gdb/linux/proc.py
> > +++ b/scripts/gdb/linux/proc.py
> > @@ -18,6 +18,7 @@ from linux import tasks
> >  from linux import lists
> >  from struct import *
> >  
> > +
> 
> This was added by patch 1, and can be squashed there.

Doh, I had deliberately done it as a separate commit, as I thought it was
a pre-existing pep8 error.

Will squash in v2.

regards,

Peter.

  reply	other threads:[~2016-10-18 15:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 15:07 [PATCH 1/2] scripts/gdb: add lx-fdtdump command Peter Griffin
     [not found] ` <1476803249-23328-1-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-18 15:07   ` [PATCH 2/2] scripts/gdb: fixup some pep8 errors in proc.py Peter Griffin
     [not found]     ` <1476803249-23328-2-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-18 15:27       ` Kieran Bingham
2016-10-18 15:57         ` Peter Griffin [this message]
2016-10-18 15:56   ` [PATCH 1/2] scripts/gdb: add lx-fdtdump command Kieran Bingham
     [not found]     ` <a440581a-e28c-2f9f-8110-26203e0b3809-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org>
2016-10-18 16:31       ` Peter Griffin
2016-10-18 15:47 ` Jan Kiszka
2016-10-18 16:06   ` Peter Griffin
2016-10-18 16:10     ` Jan Kiszka
     [not found]       ` <0143426e-7e92-aaff-7641-519e1f63e075-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2016-10-18 16:29         ` Peter Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018155757.GA24274@griffinp-ThinkPad-X1-Carbon-2nd \
    --to=peter.griffin@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kernel@stlinux.com \
    --cc=kieran@ksquared.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox