From: Pavel Machek <pavel@ucw.cz>
To: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, mchehab@kernel.org, davem@davemloft.net,
geert@linux-m68k.org, akpm@linux-foundation.org,
kvalo@codeaurora.org, linux@roeck-us.net, hverkuil@xs4all.nl,
lars@metafoo.de, robert.jarzmik@free.fr, slongerbeam@gmail.com,
dheitmueller@kernellabs.com, pali.rohar@gmail.com,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v3 2/2] Add support for Omnivision OV5647
Date: Wed, 19 Oct 2016 13:15:07 +0200 [thread overview]
Message-ID: <20161019111507.GJ1461@amd> (raw)
In-Reply-To: <375952b7-7993-b23a-10e8-85cba64b2679@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
Hi!
> >> +struct regval_list {
> >> + uint16_t addr;
> >> + uint8_t data;
> >> +};
> > u8/u16?
>
> This sensor uses 16 bits for addresses and 8 for data, so I think it makes sense
> to keep it this way.
Yes, you can do it. But please use u8/u16 types (also elsewhere in the
driver), they are more common in ther kernel.
> Thanks for the feedback. I agree with most of your suggestions, and I commented
> with the one I didn't agree.
You are welcome,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2016-10-19 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 16:02 [PATCH v3 0/2] OV5647 Sensor driver Ramiro Oliveira
2016-10-12 16:02 ` [PATCH v3 1/2] Add OV5647 device tree documentation Ramiro Oliveira
2016-10-18 13:14 ` Rob Herring
2016-10-18 13:38 ` Ramiro Oliveira
[not found] ` <cover.1476286687.git.roliveir-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-10-12 16:02 ` [PATCH v3 2/2] Add support for Omnivision OV5647 Ramiro Oliveira
[not found] ` <17092ffede9eb8aff0d6a7f54ca771e81712b18e.1476286687.git.roliveir-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-10-18 18:31 ` Pavel Machek
2016-10-19 11:12 ` Ramiro Oliveira
2016-10-19 11:15 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019111507.GJ1461@amd \
--to=pavel@ucw.cz \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dheitmueller@kernellabs.com \
--cc=geert@linux-m68k.org \
--cc=hverkuil@xs4all.nl \
--cc=kvalo@codeaurora.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).