* [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM
@ 2016-09-13 17:51 Stefan Wahren
[not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Stefan Wahren @ 2016-09-13 17:51 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam
Cc: Rob Herring, Mark Rutland, Arnd Bergmann, Marek Vasut,
Lothar Waßmann, Sascha Hauer, Jörg Krause,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Stefan Wahren
The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary
for suspend to RAM and standby mode. But before we need to remove the fake reg
properties of all internal bus nodes as discussed in this thread [1].
This patch series requires Fabio Estevam's recent series "ARM: dts: imx23:
Remove skeleton.dtsi inclusion" [2].
[1] - https://marc.info/?l=devicetree&m=146139948426520&w=2
[2] - http://www.spinics.net/lists/arm-kernel/msg528974.html
Stefan Wahren (4):
ARM: dts: imx23: Remove fake "reg" properties from bus nodes
ARM: dts: imx28: Remove fake "reg" properties from bus nodes
ARM: dts: imx23: add On-Chip RAM
ARM: dts: imx28: add On-Chip RAM
arch/arm/boot/dts/imx23-evk.dts | 8 ++++----
arch/arm/boot/dts/imx23-olinuxino.dts | 8 ++++----
arch/arm/boot/dts/imx23-sansa.dts | 8 ++++----
arch/arm/boot/dts/imx23-stmp378x_devb.dts | 6 +++---
arch/arm/boot/dts/imx23-xfi3.dts | 8 ++++----
arch/arm/boot/dts/imx23.dtsi | 15 +++++++++------
arch/arm/boot/dts/imx28-apf28.dts | 8 ++++----
arch/arm/boot/dts/imx28-apf28dev.dts | 8 ++++----
arch/arm/boot/dts/imx28-apx4devkit.dts | 8 ++++----
arch/arm/boot/dts/imx28-cfa10036.dts | 8 ++++----
arch/arm/boot/dts/imx28-cfa10037.dts | 8 ++++----
arch/arm/boot/dts/imx28-cfa10049.dts | 10 +++++-----
arch/arm/boot/dts/imx28-cfa10055.dts | 6 +++---
arch/arm/boot/dts/imx28-cfa10056.dts | 4 ++--
arch/arm/boot/dts/imx28-cfa10057.dts | 10 +++++-----
arch/arm/boot/dts/imx28-cfa10058.dts | 10 +++++-----
arch/arm/boot/dts/imx28-duckbill.dts | 8 ++++----
arch/arm/boot/dts/imx28-evk.dts | 8 ++++----
arch/arm/boot/dts/imx28-m28.dtsi | 6 +++---
arch/arm/boot/dts/imx28-m28cu3.dts | 8 ++++----
arch/arm/boot/dts/imx28-m28evk.dts | 8 ++++----
arch/arm/boot/dts/imx28-sps1.dts | 8 ++++----
arch/arm/boot/dts/imx28.dtsi | 17 +++++++++--------
23 files changed, 100 insertions(+), 96 deletions(-)
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread[parent not found: <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>]
* [PATCH 1/4] ARM: dts: imx23: Remove fake "reg" properties from bus nodes [not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> @ 2016-09-13 17:51 ` Stefan Wahren 2016-09-13 17:51 ` [PATCH 2/4] ARM: dts: imx28: " Stefan Wahren ` (4 subsequent siblings) 5 siblings, 0 replies; 11+ messages in thread From: Stefan Wahren @ 2016-09-13 17:51 UTC (permalink / raw) To: Shawn Guo, Fabio Estevam Cc: Rob Herring, Mark Rutland, Arnd Bergmann, Marek Vasut, Lothar Waßmann, Sascha Hauer, Jörg Krause, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, Stefan Wahren There is no need to specify fake "reg" properties for the internal bus nodes based on the registers of its child devices. This also avoids overlapping issues on adding the sram node. Suggested-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> --- arch/arm/boot/dts/imx23-evk.dts | 8 ++++---- arch/arm/boot/dts/imx23-olinuxino.dts | 8 ++++---- arch/arm/boot/dts/imx23-sansa.dts | 8 ++++---- arch/arm/boot/dts/imx23-stmp378x_devb.dts | 6 +++--- arch/arm/boot/dts/imx23-xfi3.dts | 8 ++++---- arch/arm/boot/dts/imx23.dtsi | 10 ++++------ 6 files changed, 23 insertions(+), 25 deletions(-) diff --git a/arch/arm/boot/dts/imx23-evk.dts b/arch/arm/boot/dts/imx23-evk.dts index bd06402..c74c648 100644 --- a/arch/arm/boot/dts/imx23-evk.dts +++ b/arch/arm/boot/dts/imx23-evk.dts @@ -21,8 +21,8 @@ reg = <0x40000000 0x08000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { gpmi-nand@8000c000 { pinctrl-names = "default"; pinctrl-0 = <&gpmi_pins_a &gpmi_pins_fixup>; @@ -90,7 +90,7 @@ }; }; - apbx@80040000 { + apbx { lradc@80050000 { status = "okay"; fsl,lradc-touchscreen-wires = <4>; @@ -120,7 +120,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { status = "okay"; }; diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts index 109f516..ae7538b 100644 --- a/arch/arm/boot/dts/imx23-olinuxino.dts +++ b/arch/arm/boot/dts/imx23-olinuxino.dts @@ -24,8 +24,8 @@ reg = <0x40000000 0x04000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { ssp0: ssp@80010000 { compatible = "fsl,imx23-mmc"; pinctrl-names = "default"; @@ -70,7 +70,7 @@ }; }; - apbx@80040000 { + apbx { lradc@80050000 { status = "okay"; }; @@ -99,7 +99,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { dr_mode = "host"; vbus-supply = <®_usb0_vbus>; diff --git a/arch/arm/boot/dts/imx23-sansa.dts b/arch/arm/boot/dts/imx23-sansa.dts index 9cf40d3..65fb08b 100644 --- a/arch/arm/boot/dts/imx23-sansa.dts +++ b/arch/arm/boot/dts/imx23-sansa.dts @@ -53,8 +53,8 @@ reg = <0x40000000 0x04000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { ssp0: ssp@80010000 { compatible = "fsl,imx23-mmc"; pinctrl-names = "default"; @@ -99,7 +99,7 @@ }; }; - apbx@80040000 { + apbx { pwm: pwm@80064000 { pinctrl-names = "default"; pinctrl-0 = <&pwm2_pins_a>; @@ -122,7 +122,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { dr_mode = "peripheral"; status = "okay"; diff --git a/arch/arm/boot/dts/imx23-stmp378x_devb.dts b/arch/arm/boot/dts/imx23-stmp378x_devb.dts index aab0293..d9b1758 100644 --- a/arch/arm/boot/dts/imx23-stmp378x_devb.dts +++ b/arch/arm/boot/dts/imx23-stmp378x_devb.dts @@ -21,8 +21,8 @@ reg = <0x40000000 0x04000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { ssp0: ssp@80010000 { compatible = "fsl,imx23-mmc"; pinctrl-names = "default"; @@ -50,7 +50,7 @@ }; }; - apbx@80040000 { + apbx { auart0: serial@8006c000 { pinctrl-names = "default"; pinctrl-0 = <&auart0_pins_a>; diff --git a/arch/arm/boot/dts/imx23-xfi3.dts b/arch/arm/boot/dts/imx23-xfi3.dts index 2b5df8d..1eb1196 100644 --- a/arch/arm/boot/dts/imx23-xfi3.dts +++ b/arch/arm/boot/dts/imx23-xfi3.dts @@ -53,8 +53,8 @@ reg = <0x40000000 0x04000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { ssp0: ssp@80010000 { compatible = "fsl,imx23-mmc"; pinctrl-names = "default"; @@ -101,7 +101,7 @@ }; }; - apbx@80040000 { + apbx { i2c: i2c@80058000 { pinctrl-names = "default"; pinctrl-0 = <&i2c_pins_a>; @@ -136,7 +136,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { dr_mode = "peripheral"; status = "okay"; diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi index 9d0e9e1..c0a59d2 100644 --- a/arch/arm/boot/dts/imx23.dtsi +++ b/arch/arm/boot/dts/imx23.dtsi @@ -38,14 +38,13 @@ }; }; - apb@80000000 { + apb { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; - reg = <0x80000000 0x80000>; ranges; - apbh@80000000 { + apbh { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; @@ -468,7 +467,7 @@ }; }; - apbx@80040000 { + apbx { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; @@ -602,11 +601,10 @@ }; }; - ahb@80080000 { + ahb { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; - reg = <0x80080000 0x80000>; ranges; usb0: usb@80080000 { -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/4] ARM: dts: imx28: Remove fake "reg" properties from bus nodes [not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> 2016-09-13 17:51 ` [PATCH 1/4] ARM: dts: imx23: Remove fake "reg" properties from bus nodes Stefan Wahren @ 2016-09-13 17:51 ` Stefan Wahren 2016-09-13 17:51 ` [PATCH 3/4] ARM: dts: imx23: add On-Chip RAM Stefan Wahren ` (3 subsequent siblings) 5 siblings, 0 replies; 11+ messages in thread From: Stefan Wahren @ 2016-09-13 17:51 UTC (permalink / raw) To: Shawn Guo, Fabio Estevam Cc: Rob Herring, Mark Rutland, Arnd Bergmann, Marek Vasut, Lothar Waßmann, Sascha Hauer, Jörg Krause, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, Stefan Wahren There is no need to specify fake "reg" properties for the internal bus nodes based on the registers of its child devices. This also avoids overlapping issues on adding the sram node. Suggested-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> --- arch/arm/boot/dts/imx28-apf28.dts | 8 ++++---- arch/arm/boot/dts/imx28-apf28dev.dts | 8 ++++---- arch/arm/boot/dts/imx28-apx4devkit.dts | 8 ++++---- arch/arm/boot/dts/imx28-cfa10036.dts | 8 ++++---- arch/arm/boot/dts/imx28-cfa10037.dts | 8 ++++---- arch/arm/boot/dts/imx28-cfa10049.dts | 10 +++++----- arch/arm/boot/dts/imx28-cfa10055.dts | 6 +++--- arch/arm/boot/dts/imx28-cfa10056.dts | 4 ++-- arch/arm/boot/dts/imx28-cfa10057.dts | 10 +++++----- arch/arm/boot/dts/imx28-cfa10058.dts | 10 +++++----- arch/arm/boot/dts/imx28-duckbill.dts | 8 ++++---- arch/arm/boot/dts/imx28-evk.dts | 8 ++++---- arch/arm/boot/dts/imx28-m28.dtsi | 6 +++--- arch/arm/boot/dts/imx28-m28cu3.dts | 8 ++++---- arch/arm/boot/dts/imx28-m28evk.dts | 8 ++++---- arch/arm/boot/dts/imx28-sps1.dts | 8 ++++---- arch/arm/boot/dts/imx28.dtsi | 12 ++++-------- 17 files changed, 67 insertions(+), 71 deletions(-) diff --git a/arch/arm/boot/dts/imx28-apf28.dts b/arch/arm/boot/dts/imx28-apf28.dts index b6976fb..e0e9b9f 100644 --- a/arch/arm/boot/dts/imx28-apf28.dts +++ b/arch/arm/boot/dts/imx28-apf28.dts @@ -21,8 +21,8 @@ reg = <0x40000000 0x08000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { gpmi-nand@8000c000 { pinctrl-names = "default"; pinctrl-0 = <&gpmi_pins_a &gpmi_status_cfg>; @@ -65,7 +65,7 @@ }; }; - apbx@80040000 { + apbx { duart: serial@80074000 { pinctrl-names = "default"; pinctrl-0 = <&duart_pins_a>; @@ -74,7 +74,7 @@ }; }; - ahb@80080000 { + ahb { mac0: ethernet@800f0000 { phy-mode = "rmii"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts index c4fadbc..1c3ecec 100644 --- a/arch/arm/boot/dts/imx28-apf28dev.dts +++ b/arch/arm/boot/dts/imx28-apf28dev.dts @@ -16,8 +16,8 @@ model = "Armadeus Systems APF28Dev docking/development board"; compatible = "armadeus,imx28-apf28dev", "armadeus,imx28-apf28", "fsl,imx28"; - apb@80000000 { - apbh@80000000 { + apb { + apbh { ssp0: ssp@80010000 { compatible = "fsl,imx28-mmc"; pinctrl-names = "default"; @@ -119,7 +119,7 @@ }; }; - apbx@80040000 { + apbx { lradc@80050000 { fsl,lradc-touchscreen-wires = <4>; status = "okay"; @@ -154,7 +154,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { pinctrl-names = "default"; pinctrl-0 = <&usb0_otg_apf28dev diff --git a/arch/arm/boot/dts/imx28-apx4devkit.dts b/arch/arm/boot/dts/imx28-apx4devkit.dts index ce6115e..f534546 100644 --- a/arch/arm/boot/dts/imx28-apx4devkit.dts +++ b/arch/arm/boot/dts/imx28-apx4devkit.dts @@ -10,8 +10,8 @@ reg = <0x40000000 0x04000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { gpmi-nand@8000c000 { pinctrl-names = "default"; pinctrl-0 = <&gpmi_pins_a &gpmi_status_cfg>; @@ -124,7 +124,7 @@ }; }; - apbx@80040000 { + apbx { saif0: saif@80042000 { pinctrl-names = "default"; pinctrl-0 = <&saif0_pins_a>; @@ -183,7 +183,7 @@ }; }; - ahb@80080000 { + ahb { mac0: ethernet@800f0000 { phy-mode = "rmii"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/imx28-cfa10036.dts b/arch/arm/boot/dts/imx28-cfa10036.dts index d016a3b..dc54b40 100644 --- a/arch/arm/boot/dts/imx28-cfa10036.dts +++ b/arch/arm/boot/dts/imx28-cfa10036.dts @@ -21,8 +21,8 @@ reg = <0x40000000 0x08000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { pinctrl@80018000 { ssd1306_cfa10036: ssd1306-10036@0 { reg = <0>; @@ -78,7 +78,7 @@ }; }; - apbx@80040000 { + apbx { duart: serial@80074000 { pinctrl-names = "default"; pinctrl-0 = <&duart_pins_b>; @@ -112,7 +112,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { pinctrl-names = "default"; pinctrl-0 = <&usb0_otg_cfa10036>; diff --git a/arch/arm/boot/dts/imx28-cfa10037.dts b/arch/arm/boot/dts/imx28-cfa10037.dts index e5beaa5..e6bc433 100644 --- a/arch/arm/boot/dts/imx28-cfa10037.dts +++ b/arch/arm/boot/dts/imx28-cfa10037.dts @@ -19,8 +19,8 @@ model = "Crystalfontz CFA-10037 Board"; compatible = "crystalfontz,cfa10037", "crystalfontz,cfa10036", "fsl,imx28"; - apb@80000000 { - apbh@80000000 { + apb { + apbh { pinctrl@80018000 { usb_pins_cfa10037: usb-10037@0 { reg = <0>; @@ -44,14 +44,14 @@ }; }; - apbx@80040000 { + apbx { usbphy1: usbphy@8007e000 { status = "okay"; }; }; }; - ahb@80080000 { + ahb { usb1: usb@80090000 { vbus-supply = <®_usb1_vbus>; pinctrl-0 = <&usb1_pins_a>; diff --git a/arch/arm/boot/dts/imx28-cfa10049.dts b/arch/arm/boot/dts/imx28-cfa10049.dts index a9c347e..219644b 100644 --- a/arch/arm/boot/dts/imx28-cfa10049.dts +++ b/arch/arm/boot/dts/imx28-cfa10049.dts @@ -19,8 +19,8 @@ model = "Crystalfontz CFA-10049 Board"; compatible = "crystalfontz,cfa10049", "crystalfontz,cfa10036", "fsl,imx28"; - apb@80000000 { - apbh@80000000 { + apb { + apbh { pinctrl@80018000 { usb_pins_cfa10049: usb-10049@0 { reg = <0>; @@ -206,7 +206,7 @@ }; }; - apbx@80040000 { + apbx { pwm: pwm@80064000 { pinctrl-names = "default"; pinctrl-0 = <&pwm3_pins_b>; @@ -295,7 +295,7 @@ }; }; - ahb@80080000 { + ahb { usb1: usb@80090000 { vbus-supply = <®_usb1_vbus>; pinctrl-0 = <&usb1_pins_a>; @@ -321,7 +321,7 @@ }; }; - ahb@80080000 { + ahb { mac0: ethernet@800f0000 { phy-mode = "rmii"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/imx28-cfa10055.dts b/arch/arm/boot/dts/imx28-cfa10055.dts index 6a34114..51debef 100644 --- a/arch/arm/boot/dts/imx28-cfa10055.dts +++ b/arch/arm/boot/dts/imx28-cfa10055.dts @@ -20,8 +20,8 @@ model = "Crystalfontz CFA-10055 Board"; compatible = "crystalfontz,cfa10055", "crystalfontz,cfa10037", "crystalfontz,cfa10036", "fsl,imx28"; - apb@80000000 { - apbh@80000000 { + apb { + apbh { pinctrl@80018000 { spi2_pins_cfa10055: spi2-cfa10055@0 { reg = <0>; @@ -121,7 +121,7 @@ }; }; - apbx@80040000 { + apbx { lradc@80050000 { fsl,lradc-touchscreen-wires = <4>; status = "okay"; diff --git a/arch/arm/boot/dts/imx28-cfa10056.dts b/arch/arm/boot/dts/imx28-cfa10056.dts index ba6495c..b7a4075 100644 --- a/arch/arm/boot/dts/imx28-cfa10056.dts +++ b/arch/arm/boot/dts/imx28-cfa10056.dts @@ -19,8 +19,8 @@ model = "Crystalfontz CFA-10056 Board"; compatible = "crystalfontz,cfa10056", "crystalfontz,cfa10037", "crystalfontz,cfa10036", "fsl,imx28"; - apb@80000000 { - apbh@80000000 { + apb { + apbh { pinctrl@80018000 { spi2_pins_cfa10056: spi2-cfa10056@0 { reg = <0>; diff --git a/arch/arm/boot/dts/imx28-cfa10057.dts b/arch/arm/boot/dts/imx28-cfa10057.dts index 7a80bd6..a866f28 100644 --- a/arch/arm/boot/dts/imx28-cfa10057.dts +++ b/arch/arm/boot/dts/imx28-cfa10057.dts @@ -20,8 +20,8 @@ model = "Crystalfontz CFA-10057 Board"; compatible = "crystalfontz,cfa10057", "crystalfontz,cfa10036", "fsl,imx28"; - apb@80000000 { - apbh@80000000 { + apb { + apbh { pinctrl@80018000 { usb_pins_cfa10057: usb-10057@0 { reg = <0>; @@ -107,7 +107,7 @@ }; }; - apbx@80040000 { + apbx { lradc@80050000 { fsl,lradc-touchscreen-wires = <4>; status = "okay"; @@ -131,7 +131,7 @@ }; }; - ahb@80080000 { + ahb { usb1: usb@80090000 { vbus-supply = <®_usb1_vbus>; pinctrl-0 = <&usb1_pins_a>; @@ -157,7 +157,7 @@ }; }; - ahb@80080000 { + ahb { mac0: ethernet@800f0000 { phy-mode = "rmii"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/imx28-cfa10058.dts b/arch/arm/boot/dts/imx28-cfa10058.dts index f5c6dce..4e396a8 100644 --- a/arch/arm/boot/dts/imx28-cfa10058.dts +++ b/arch/arm/boot/dts/imx28-cfa10058.dts @@ -20,8 +20,8 @@ model = "Crystalfontz CFA-10058 Board"; compatible = "crystalfontz,cfa10058", "crystalfontz,cfa10036", "fsl,imx28"; - apb@80000000 { - apbh@80000000 { + apb { + apbh { pinctrl@80018000 { usb_pins_cfa10058: usb-10058@0 { reg = <0>; @@ -80,7 +80,7 @@ }; }; - apbx@80040000 { + apbx { lradc@80050000 { fsl,lradc-touchscreen-wires = <4>; status = "okay"; @@ -98,7 +98,7 @@ }; }; - ahb@80080000 { + ahb { usb1: usb@80090000 { vbus-supply = <®_usb1_vbus>; pinctrl-0 = <&usb1_pins_a>; @@ -124,7 +124,7 @@ }; }; - ahb@80080000 { + ahb { mac0: ethernet@800f0000 { phy-mode = "rmii"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/imx28-duckbill.dts b/arch/arm/boot/dts/imx28-duckbill.dts index b5bc3f5..1d92c61 100644 --- a/arch/arm/boot/dts/imx28-duckbill.dts +++ b/arch/arm/boot/dts/imx28-duckbill.dts @@ -21,8 +21,8 @@ reg = <0x40000000 0x08000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { ssp0: ssp@80010000 { compatible = "fsl,imx28-mmc"; pinctrl-names = "default"; @@ -60,7 +60,7 @@ }; }; - apbx@80040000 { + apbx { duart: serial@80074000 { pinctrl-names = "default"; pinctrl-0 = <&duart_pins_a>; @@ -73,7 +73,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { status = "okay"; }; diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts index 4cd8216..f502054 100644 --- a/arch/arm/boot/dts/imx28-evk.dts +++ b/arch/arm/boot/dts/imx28-evk.dts @@ -21,8 +21,8 @@ reg = <0x40000000 0x08000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { gpmi-nand@8000c000 { pinctrl-names = "default"; pinctrl-0 = <&gpmi_pins_a &gpmi_status_cfg @@ -168,7 +168,7 @@ }; }; - apbx@80040000 { + apbx { saif0: saif@80042000 { pinctrl-names = "default"; pinctrl-0 = <&saif0_pins_a>; @@ -245,7 +245,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { pinctrl-names = "default"; pinctrl-0 = <&usb0_id_pins_a>; diff --git a/arch/arm/boot/dts/imx28-m28.dtsi b/arch/arm/boot/dts/imx28-m28.dtsi index 1bcba90..e4f50f0d 100644 --- a/arch/arm/boot/dts/imx28-m28.dtsi +++ b/arch/arm/boot/dts/imx28-m28.dtsi @@ -20,8 +20,8 @@ reg = <0x40000000 0x08000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { gpmi-nand@8000c000 { #address-cells = <1>; #size-cells = <1>; @@ -31,7 +31,7 @@ }; }; - apbx@80040000 { + apbx { i2c0: i2c@80058000 { pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins_a>; diff --git a/arch/arm/boot/dts/imx28-m28cu3.dts b/arch/arm/boot/dts/imx28-m28cu3.dts index c4c4cc7..556020f 100644 --- a/arch/arm/boot/dts/imx28-m28cu3.dts +++ b/arch/arm/boot/dts/imx28-m28cu3.dts @@ -21,8 +21,8 @@ reg = <0x40000000 0x08000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { gpmi-nand@8000c000 { #address-cells = <1>; #size-cells = <1>; @@ -145,7 +145,7 @@ }; }; - apbx@80040000 { + apbx { duart: serial@80074000 { pinctrl-names = "default"; pinctrl-0 = <&duart_pins_b>; @@ -176,7 +176,7 @@ }; }; - ahb@80080000 { + ahb { usb1: usb@80090000 { vbus-supply = <®_usb1_vbus>; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/imx28-m28evk.dts b/arch/arm/boot/dts/imx28-m28evk.dts index 8d04e57..f9bbe66 100644 --- a/arch/arm/boot/dts/imx28-m28evk.dts +++ b/arch/arm/boot/dts/imx28-m28evk.dts @@ -16,8 +16,8 @@ model = "DENX M28EVK"; compatible = "denx,m28evk", "fsl,imx28"; - apb@80000000 { - apbh@80000000 { + apb { + apbh { ssp0: ssp@80010000 { compatible = "fsl,imx28-mmc"; pinctrl-names = "default"; @@ -122,7 +122,7 @@ }; }; - apbx@80040000 { + apbx { saif0: saif@80042000 { pinctrl-names = "default"; pinctrl-0 = <&saif0_pins_a>; @@ -197,7 +197,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { vbus-supply = <®_usb0_vbus>; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/imx28-sps1.dts b/arch/arm/boot/dts/imx28-sps1.dts index 5ddfb16..52482ba 100644 --- a/arch/arm/boot/dts/imx28-sps1.dts +++ b/arch/arm/boot/dts/imx28-sps1.dts @@ -21,8 +21,8 @@ reg = <0x40000000 0x08000000>; }; - apb@80000000 { - apbh@80000000 { + apb { + apbh { pinctrl@80018000 { pinctrl-names = "default"; pinctrl-0 = <&hog_pins_a>; @@ -67,7 +67,7 @@ }; }; - apbx@80040000 { + apbx { i2c0: i2c@80058000 { pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins_a>; @@ -103,7 +103,7 @@ }; }; - ahb@80080000 { + ahb { usb0: usb@80080000 { vbus-supply = <®_usb0_vbus>; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 3aabf65..e483f61 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -49,18 +49,16 @@ }; }; - apb@80000000 { + apb { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; - reg = <0x80000000 0x80000>; ranges; - apbh@80000000 { + apbh { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; - reg = <0x80000000 0x3c900>; ranges; icoll: interrupt-controller@80000000 { @@ -1056,11 +1054,10 @@ }; }; - apbx@80040000 { + apbx { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; - reg = <0x80040000 0x40000>; ranges; clks: clkctrl@80040000 { @@ -1234,11 +1231,10 @@ }; }; - ahb@80080000 { + ahb { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; - reg = <0x80080000 0x80000>; ranges; usb0: usb@80080000 { -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/4] ARM: dts: imx23: add On-Chip RAM [not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> 2016-09-13 17:51 ` [PATCH 1/4] ARM: dts: imx23: Remove fake "reg" properties from bus nodes Stefan Wahren 2016-09-13 17:51 ` [PATCH 2/4] ARM: dts: imx28: " Stefan Wahren @ 2016-09-13 17:51 ` Stefan Wahren 2016-09-13 17:51 ` [PATCH 4/4] ARM: dts: imx28: " Stefan Wahren ` (2 subsequent siblings) 5 siblings, 0 replies; 11+ messages in thread From: Stefan Wahren @ 2016-09-13 17:51 UTC (permalink / raw) To: Shawn Guo, Fabio Estevam Cc: Rob Herring, Mark Rutland, Arnd Bergmann, Marek Vasut, Lothar Waßmann, Sascha Hauer, Jörg Krause, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, Stefan Wahren This patch adds the node for the 32 KB On-Chip RAM of the i.MX23. Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> --- arch/arm/boot/dts/imx23.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi index c0a59d2..b66e372 100644 --- a/arch/arm/boot/dts/imx23.dtsi +++ b/arch/arm/boot/dts/imx23.dtsi @@ -607,6 +607,11 @@ #size-cells = <1>; ranges; + ocram: sram@00000000 { + compatible = "mmio-sram"; + reg = <0x00000000 0x8000>; + }; + usb0: usb@80080000 { compatible = "fsl,imx23-usb", "fsl,imx27-usb"; reg = <0x80080000 0x40000>; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/4] ARM: dts: imx28: add On-Chip RAM [not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> ` (2 preceding siblings ...) 2016-09-13 17:51 ` [PATCH 3/4] ARM: dts: imx23: add On-Chip RAM Stefan Wahren @ 2016-09-13 17:51 ` Stefan Wahren 2016-10-20 15:33 ` [PATCH 0/4] ARM: boot: mxs: Add " Stefan Wahren 2016-10-21 13:53 ` Shawn Guo 5 siblings, 0 replies; 11+ messages in thread From: Stefan Wahren @ 2016-09-13 17:51 UTC (permalink / raw) To: Shawn Guo, Fabio Estevam Cc: Rob Herring, Mark Rutland, Arnd Bergmann, Marek Vasut, Lothar Waßmann, Sascha Hauer, Jörg Krause, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, Stefan Wahren This patch adds the node for the 128 KB On-Chip RAM of the i.MX28. Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> --- arch/arm/boot/dts/imx28.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index e483f61..eefff7e1 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -1237,6 +1237,11 @@ #size-cells = <1>; ranges; + ocram: sram@00000000 { + compatible = "mmio-sram"; + reg = <0x00000000 0x20000>; + }; + usb0: usb@80080000 { compatible = "fsl,imx28-usb", "fsl,imx27-usb"; reg = <0x80080000 0x10000>; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM [not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> ` (3 preceding siblings ...) 2016-09-13 17:51 ` [PATCH 4/4] ARM: dts: imx28: " Stefan Wahren @ 2016-10-20 15:33 ` Stefan Wahren 2016-10-21 13:53 ` Shawn Guo 5 siblings, 0 replies; 11+ messages in thread From: Stefan Wahren @ 2016-10-20 15:33 UTC (permalink / raw) To: Shawn Guo, Fabio Estevam Cc: Rob Herring, Mark Rutland, Arnd Bergmann, Marek Vasut, Lothar Waßmann, Sascha Hauer, Jörg Krause, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA Am 13.09.2016 um 19:51 schrieb Stefan Wahren: > The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary > for suspend to RAM and standby mode. But before we need to remove the fake reg > properties of all internal bus nodes as discussed in this thread [1]. > > This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: > Remove skeleton.dtsi inclusion" [2]. > > [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 > [2] - http://www.spinics.net/lists/arm-kernel/msg528974.html > > Stefan Wahren (4): > ARM: dts: imx23: Remove fake "reg" properties from bus nodes > ARM: dts: imx28: Remove fake "reg" properties from bus nodes > ARM: dts: imx23: add On-Chip RAM > ARM: dts: imx28: add On-Chip RAM > > arch/arm/boot/dts/imx23-evk.dts | 8 ++++---- > arch/arm/boot/dts/imx23-olinuxino.dts | 8 ++++---- > arch/arm/boot/dts/imx23-sansa.dts | 8 ++++---- > arch/arm/boot/dts/imx23-stmp378x_devb.dts | 6 +++--- > arch/arm/boot/dts/imx23-xfi3.dts | 8 ++++---- > arch/arm/boot/dts/imx23.dtsi | 15 +++++++++------ > arch/arm/boot/dts/imx28-apf28.dts | 8 ++++---- > arch/arm/boot/dts/imx28-apf28dev.dts | 8 ++++---- > arch/arm/boot/dts/imx28-apx4devkit.dts | 8 ++++---- > arch/arm/boot/dts/imx28-cfa10036.dts | 8 ++++---- > arch/arm/boot/dts/imx28-cfa10037.dts | 8 ++++---- > arch/arm/boot/dts/imx28-cfa10049.dts | 10 +++++----- > arch/arm/boot/dts/imx28-cfa10055.dts | 6 +++--- > arch/arm/boot/dts/imx28-cfa10056.dts | 4 ++-- > arch/arm/boot/dts/imx28-cfa10057.dts | 10 +++++----- > arch/arm/boot/dts/imx28-cfa10058.dts | 10 +++++----- > arch/arm/boot/dts/imx28-duckbill.dts | 8 ++++---- > arch/arm/boot/dts/imx28-evk.dts | 8 ++++---- > arch/arm/boot/dts/imx28-m28.dtsi | 6 +++--- > arch/arm/boot/dts/imx28-m28cu3.dts | 8 ++++---- > arch/arm/boot/dts/imx28-m28evk.dts | 8 ++++---- > arch/arm/boot/dts/imx28-sps1.dts | 8 ++++---- > arch/arm/boot/dts/imx28.dtsi | 17 +++++++++-------- > 23 files changed, 100 insertions(+), 96 deletions(-) > Any comments about this series or should i resend it without Fabio's patch series applied? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM [not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> ` (4 preceding siblings ...) 2016-10-20 15:33 ` [PATCH 0/4] ARM: boot: mxs: Add " Stefan Wahren @ 2016-10-21 13:53 ` Shawn Guo 2016-10-21 14:05 ` Stefan Wahren 5 siblings, 1 reply; 11+ messages in thread From: Shawn Guo @ 2016-10-21 13:53 UTC (permalink / raw) To: Stefan Wahren Cc: Fabio Estevam, Mark Rutland, Marek Vasut, Arnd Bergmann, devicetree-u79uwXL29TY76Z2rM5mHXA, Jörg Krause, Rob Herring, Sascha Hauer, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Lothar Waßmann On Tue, Sep 13, 2016 at 05:51:02PM +0000, Stefan Wahren wrote: > The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary > for suspend to RAM and standby mode. But before we need to remove the fake reg > properties of all internal bus nodes as discussed in this thread [1]. > > This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: > Remove skeleton.dtsi inclusion" [2]. > > [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 The page cannot be reached. I would like to understand the background for this change. Shawn > [2] - http://www.spinics.net/lists/arm-kernel/msg528974.html > > Stefan Wahren (4): > ARM: dts: imx23: Remove fake "reg" properties from bus nodes > ARM: dts: imx28: Remove fake "reg" properties from bus nodes > ARM: dts: imx23: add On-Chip RAM > ARM: dts: imx28: add On-Chip RAM > > arch/arm/boot/dts/imx23-evk.dts | 8 ++++---- > arch/arm/boot/dts/imx23-olinuxino.dts | 8 ++++---- > arch/arm/boot/dts/imx23-sansa.dts | 8 ++++---- > arch/arm/boot/dts/imx23-stmp378x_devb.dts | 6 +++--- > arch/arm/boot/dts/imx23-xfi3.dts | 8 ++++---- > arch/arm/boot/dts/imx23.dtsi | 15 +++++++++------ > arch/arm/boot/dts/imx28-apf28.dts | 8 ++++---- > arch/arm/boot/dts/imx28-apf28dev.dts | 8 ++++---- > arch/arm/boot/dts/imx28-apx4devkit.dts | 8 ++++---- > arch/arm/boot/dts/imx28-cfa10036.dts | 8 ++++---- > arch/arm/boot/dts/imx28-cfa10037.dts | 8 ++++---- > arch/arm/boot/dts/imx28-cfa10049.dts | 10 +++++----- > arch/arm/boot/dts/imx28-cfa10055.dts | 6 +++--- > arch/arm/boot/dts/imx28-cfa10056.dts | 4 ++-- > arch/arm/boot/dts/imx28-cfa10057.dts | 10 +++++----- > arch/arm/boot/dts/imx28-cfa10058.dts | 10 +++++----- > arch/arm/boot/dts/imx28-duckbill.dts | 8 ++++---- > arch/arm/boot/dts/imx28-evk.dts | 8 ++++---- > arch/arm/boot/dts/imx28-m28.dtsi | 6 +++--- > arch/arm/boot/dts/imx28-m28cu3.dts | 8 ++++---- > arch/arm/boot/dts/imx28-m28evk.dts | 8 ++++---- > arch/arm/boot/dts/imx28-sps1.dts | 8 ++++---- > arch/arm/boot/dts/imx28.dtsi | 17 +++++++++-------- > 23 files changed, 100 insertions(+), 96 deletions(-) > > -- > 1.7.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM 2016-10-21 13:53 ` Shawn Guo @ 2016-10-21 14:05 ` Stefan Wahren [not found] ` <9bf7c925-bdc2-d0b8-9886-70d46383d1e0-eS4NqCHxEME@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Stefan Wahren @ 2016-10-21 14:05 UTC (permalink / raw) To: Shawn Guo Cc: Fabio Estevam, Mark Rutland, Marek Vasut, Arnd Bergmann, devicetree-u79uwXL29TY76Z2rM5mHXA, Jörg Krause, Rob Herring, Sascha Hauer, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Lothar Waßmann Am 21.10.2016 um 15:53 schrieb Shawn Guo: > On Tue, Sep 13, 2016 at 05:51:02PM +0000, Stefan Wahren wrote: >> The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary >> for suspend to RAM and standby mode. But before we need to remove the fake reg >> properties of all internal bus nodes as discussed in this thread [1]. >> >> This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: >> Remove skeleton.dtsi inclusion" [2]. >> >> [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 > The page cannot be reached. I would like to understand the > background for this change. Strange, because i don't have any problems while clicking on the URL. It's an older discussion on the devicetree / kernel newbie mailing list with subject "strange dtc errors after adding sram node". Arnd suggested in the discussion to remove the reg property from the ahb node. Please try this one: http://www.spinics.net/lists/newbies/msg57652.html Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <9bf7c925-bdc2-d0b8-9886-70d46383d1e0-eS4NqCHxEME@public.gmane.org>]
* Re: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM [not found] ` <9bf7c925-bdc2-d0b8-9886-70d46383d1e0-eS4NqCHxEME@public.gmane.org> @ 2016-10-21 15:03 ` Shawn Guo 2016-10-21 15:24 ` Stefan Wahren 0 siblings, 1 reply; 11+ messages in thread From: Shawn Guo @ 2016-10-21 15:03 UTC (permalink / raw) To: Stefan Wahren Cc: Mark Rutland, Marek Vasut, Arnd Bergmann, devicetree-u79uwXL29TY76Z2rM5mHXA, Jörg Krause, Rob Herring, Sascha Hauer, Fabio Estevam, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Lothar Waßmann On Fri, Oct 21, 2016 at 04:05:59PM +0200, Stefan Wahren wrote: > Am 21.10.2016 um 15:53 schrieb Shawn Guo: > > On Tue, Sep 13, 2016 at 05:51:02PM +0000, Stefan Wahren wrote: > >> The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary > >> for suspend to RAM and standby mode. But before we need to remove the fake reg > >> properties of all internal bus nodes as discussed in this thread [1]. > >> > >> This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: > >> Remove skeleton.dtsi inclusion" [2]. > >> > >> [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 > > The page cannot be reached. I would like to understand the > > background for this change. > > Strange, because i don't have any problems while clicking on the URL. > > It's an older discussion on the devicetree / kernel newbie mailing list > with subject "strange dtc errors after adding sram node". Arnd suggested > in the discussion to remove the reg property from the ahb node. > > Please try this one: http://www.spinics.net/lists/newbies/msg57652.html If you go through 'Table 4-1. Address Map for i.MX28' of MCIMX28RM, you should be able to find there are 3 AHB buses: ahb@0, ahb@80080000 and ahb@c0000000. The ocram goes to ahb@0. The following change should be the right one for ocram addition. diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 0ad893bf5f43..8e5718df06b2 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -47,6 +47,19 @@ }; }; + ahb@0 { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + reg = <0x0 0x80000000>; + ranges; + + ocram: sram@0 { + compatible = "mmio-sram"; + reg = <0x0 0x20000>; + }; + }; + apb@80000000 { compatible = "simple-bus"; #address-cells = <1>; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM 2016-10-21 15:03 ` Shawn Guo @ 2016-10-21 15:24 ` Stefan Wahren [not found] ` <e472fb62-00d2-359d-2126-ce2727fe3bed-eS4NqCHxEME@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Stefan Wahren @ 2016-10-21 15:24 UTC (permalink / raw) To: Shawn Guo Cc: Mark Rutland, Marek Vasut, Arnd Bergmann, devicetree-u79uwXL29TY76Z2rM5mHXA, Jörg Krause, Rob Herring, Sascha Hauer, Fabio Estevam, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Lothar Waßmann Am 21.10.2016 um 17:03 schrieb Shawn Guo: > On Fri, Oct 21, 2016 at 04:05:59PM +0200, Stefan Wahren wrote: >> Am 21.10.2016 um 15:53 schrieb Shawn Guo: >>> On Tue, Sep 13, 2016 at 05:51:02PM +0000, Stefan Wahren wrote: >>>> The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary >>>> for suspend to RAM and standby mode. But before we need to remove the fake reg >>>> properties of all internal bus nodes as discussed in this thread [1]. >>>> >>>> This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: >>>> Remove skeleton.dtsi inclusion" [2]. >>>> >>>> [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 >>> The page cannot be reached. I would like to understand the >>> background for this change. >> Strange, because i don't have any problems while clicking on the URL. >> >> It's an older discussion on the devicetree / kernel newbie mailing list >> with subject "strange dtc errors after adding sram node". Arnd suggested >> in the discussion to remove the reg property from the ahb node. >> >> Please try this one: http://www.spinics.net/lists/newbies/msg57652.html > If you go through 'Table 4-1. Address Map for i.MX28' of MCIMX28RM, you > should be able to find there are 3 AHB buses: ahb@0, ahb@80080000 and > ahb@c0000000. The ocram goes to ahb@0. The following change should be > the right one for ocram addition. Correct me if i'm wrong, but there is only one AHB bus and only the connected peripheral devices like ocram or USB controller have a memory mapped start address not the bus itself. > > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > index 0ad893bf5f43..8e5718df06b2 100644 > --- a/arch/arm/boot/dts/imx28.dtsi > +++ b/arch/arm/boot/dts/imx28.dtsi > @@ -47,6 +47,19 @@ > }; > }; > > + ahb@0 { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x0 0x80000000>; > + ranges; > + > + ocram: sram@0 { > + compatible = "mmio-sram"; > + reg = <0x0 0x20000>; > + }; > + }; > + > apb@80000000 { > compatible = "simple-bus"; > #address-cells = <1>; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <e472fb62-00d2-359d-2126-ce2727fe3bed-eS4NqCHxEME@public.gmane.org>]
* Re: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM [not found] ` <e472fb62-00d2-359d-2126-ce2727fe3bed-eS4NqCHxEME@public.gmane.org> @ 2016-10-21 15:30 ` Stefan Wahren 0 siblings, 0 replies; 11+ messages in thread From: Stefan Wahren @ 2016-10-21 15:30 UTC (permalink / raw) To: Shawn Guo Cc: Mark Rutland, Marek Vasut, Arnd Bergmann, devicetree-u79uwXL29TY76Z2rM5mHXA, Jörg Krause, Rob Herring, Sascha Hauer, Fabio Estevam, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Lothar Waßmann Am 21.10.2016 um 17:24 schrieb Stefan Wahren: > Am 21.10.2016 um 17:03 schrieb Shawn Guo: >> On Fri, Oct 21, 2016 at 04:05:59PM +0200, Stefan Wahren wrote: >>> Am 21.10.2016 um 15:53 schrieb Shawn Guo: >>>> On Tue, Sep 13, 2016 at 05:51:02PM +0000, Stefan Wahren wrote: >>>>> The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary >>>>> for suspend to RAM and standby mode. But before we need to remove the fake reg >>>>> properties of all internal bus nodes as discussed in this thread [1]. >>>>> >>>>> This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: >>>>> Remove skeleton.dtsi inclusion" [2]. >>>>> >>>>> [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 >>>> The page cannot be reached. I would like to understand the >>>> background for this change. >>> Strange, because i don't have any problems while clicking on the URL. >>> >>> It's an older discussion on the devicetree / kernel newbie mailing list >>> with subject "strange dtc errors after adding sram node". Arnd suggested >>> in the discussion to remove the reg property from the ahb node. >>> >>> Please try this one: http://www.spinics.net/lists/newbies/msg57652.html >> If you go through 'Table 4-1. Address Map for i.MX28' of MCIMX28RM, you >> should be able to find there are 3 AHB buses: ahb@0, ahb@80080000 and >> ahb@c0000000. The ocram goes to ahb@0. The following change should be >> the right one for ocram addition. > Correct me if i'm wrong, but there is only one AHB bus and only the > connected peripheral devices like ocram or USB controller have a memory > mapped start address not the bus itself. Please forget about that. According to the reference manual there are 3 AHB bus layers. > >> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi >> index 0ad893bf5f43..8e5718df06b2 100644 >> --- a/arch/arm/boot/dts/imx28.dtsi >> +++ b/arch/arm/boot/dts/imx28.dtsi >> @@ -47,6 +47,19 @@ >> }; >> }; >> >> + ahb@0 { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + reg = <0x0 0x80000000>; >> + ranges; >> + >> + ocram: sram@0 { >> + compatible = "mmio-sram"; >> + reg = <0x0 0x20000>; >> + }; >> + }; >> + >> apb@80000000 { >> compatible = "simple-bus"; >> #address-cells = <1>; >> > -- Software-Entwickler / software developer I2SE GmbH Tel: +49 (0) 341 355667-00 Friedrich-Ebert-Str. 61 Fax: +49 (0) 341 355667-02 04109 Leipzig Germany Web: http://www.i2se.com/ Mail: info-eS4NqCHxEME@public.gmane.org VAT No.: DE 811528334 Amtsgericht Leipzig HRB 23784 Geschäftsführer/CEO: Carsten Ziermann *** Diese E-Mail ist allein für den bezeichneten Adressaten bestimmt. Sie kann rechtlich vertrauliche Informationen enthalten. Wenn Sie diese E-Mail irrtümlich erhalten haben, informieren Sie bitte unverzüglich den Absender per E-Mail und löschen Sie diese E-Mail von Ihrem Computer, ohne Kopien anzufertigen. Vielen Dank. *** *** This email is for the exclusive use of the addressee. It may contain legally privileged information. If you have received this message in error, please notify the sender by email immediately and delete the message from your computer without making any copies. Thank you. *** -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-10-21 15:30 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-13 17:51 [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM Stefan Wahren
[not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-09-13 17:51 ` [PATCH 1/4] ARM: dts: imx23: Remove fake "reg" properties from bus nodes Stefan Wahren
2016-09-13 17:51 ` [PATCH 2/4] ARM: dts: imx28: " Stefan Wahren
2016-09-13 17:51 ` [PATCH 3/4] ARM: dts: imx23: add On-Chip RAM Stefan Wahren
2016-09-13 17:51 ` [PATCH 4/4] ARM: dts: imx28: " Stefan Wahren
2016-10-20 15:33 ` [PATCH 0/4] ARM: boot: mxs: Add " Stefan Wahren
2016-10-21 13:53 ` Shawn Guo
2016-10-21 14:05 ` Stefan Wahren
[not found] ` <9bf7c925-bdc2-d0b8-9886-70d46383d1e0-eS4NqCHxEME@public.gmane.org>
2016-10-21 15:03 ` Shawn Guo
2016-10-21 15:24 ` Stefan Wahren
[not found] ` <e472fb62-00d2-359d-2126-ce2727fe3bed-eS4NqCHxEME@public.gmane.org>
2016-10-21 15:30 ` Stefan Wahren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).