From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jeremy McNicoll <jeremymc@redhat.com>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org,
andy.gross@linaro.org, sboyd@codeaurora.org, arnd@arndb.de,
mark.rutland@arm.com, michael.scott@linaro.org
Subject: Re: [RFC V4 PATCH 1/6] arm64: dts: msm8992 SoC and LG Bullhead (Nexus 5X) support
Date: Fri, 21 Oct 2016 11:20:04 -0700 [thread overview]
Message-ID: <20161021182004.GW7509@tuxbot> (raw)
In-Reply-To: <1477048273-32451-2-git-send-email-jeremymc@redhat.com>
On Fri 21 Oct 04:11 PDT 2016, Jeremy McNicoll wrote:
> From: Jeremy McNicoll <jmcnicol@redhat.com>
>
> Initial device tree support for Qualcomm MSM8992 SoC and
> LG Bullhead / Google Nexus 5X support.
>
Looks reasonable, just two small nits below.
> Signed-off-by: Jeremy McNicoll <jeremymc@redhat.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 4 +-
> .../boot/dts/qcom/msm8992-bullhead-rev-101.dts | 42 ++++
> arch/arm64/boot/dts/qcom/msm8992-pins.dtsi | 38 ++++
> arch/arm64/boot/dts/qcom/msm8992.dtsi | 214 +++++++++++++++++++++
> 4 files changed, 296 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts
> create mode 100644 arch/arm64/boot/dts/qcom/msm8992-pins.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/msm8992.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 5dd05de..abb366e 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -1,6 +1,6 @@
> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb apq8096-db820c.dtb
Don't change these, just add yours.
[..]
> diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992.dtsi
[..]
> +
> + msmgpio: pinctrl@fd510000 {
> + compatible = "qcom,msm8994-pinctrl", "qcom,msm8974-pinctrl";
This device is not compatible with the msm8974 TLMM, so please drop the
second compatible.
> + reg = <0xfd510000 0x4000>;
> + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
Regards,
Bjorn
next prev parent reply other threads:[~2016-10-21 18:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 11:11 [RFC V4 PATCH 0/6] msm8992/msm8994: Google Nexus 5X/6P initial board support Jeremy McNicoll
[not found] ` <1477048273-32451-1-git-send-email-jeremymc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-21 11:11 ` [RFC V4 PATCH 1/6] arm64: dts: msm8992 SoC and LG Bullhead (Nexus 5X) support Jeremy McNicoll
2016-10-21 18:20 ` Bjorn Andersson [this message]
2016-10-25 8:15 ` Jeremy McNicoll
[not found] ` <1477048273-32451-2-git-send-email-jeremymc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-21 19:21 ` Stephen Boyd
[not found] ` <20161021192147.GM26139-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-10-25 9:40 ` Jeremy McNicoll
2016-10-25 10:41 ` Jeremy McNicoll
2016-10-21 11:11 ` [RFC V4 PATCH 2/6] dt-bindings: qcom: clocks: Add msm8994 clock bindings Jeremy McNicoll
2016-10-21 11:11 ` [RFC V4 PATCH 3/6] msm8994 clocks: global clock support for msm8994 SOC Jeremy McNicoll
2016-10-21 11:11 ` [RFC V4 PATCH 4/6] dt-bindings: qcom: Add msm899(2/4) bindings Jeremy McNicoll
2016-10-21 11:11 ` [RFC V4 PATCH 6/6] arm64: configs: enable configs for msm899(2/4) basic support Jeremy McNicoll
[not found] ` <1477048273-32451-7-git-send-email-jeremymc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-21 18:27 ` Bjorn Andersson
2016-10-21 22:32 ` Jeremy McNicoll
2016-10-25 8:07 ` Jeremy McNicoll
2016-10-21 11:11 ` [RFC V4 PATCH 5/6] arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support Jeremy McNicoll
2016-10-21 18:25 ` Bjorn Andersson
2016-10-25 8:00 ` Jeremy McNicoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021182004.GW7509@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jeremymc@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.scott@linaro.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).