From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 1/3] mtd: s3c2410: make ecc mode configurable via platform data Date: Sat, 22 Oct 2016 18:32:08 +0300 Message-ID: <20161022153208.GA3830@kozik-lap> References: <1476999766-32526-1-git-send-email-sergio.prado@e-labworks.com> <1476999766-32526-2-git-send-email-sergio.prado@e-labworks.com> <20161021182710.GA17279@kozik-lap> <20161022142907.08a3eedf@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20161022142907.08a3eedf@bbrezillon> Sender: linux-samsung-soc-owner@vger.kernel.org To: Boris Brezillon Cc: Krzysztof Kozlowski , Sergio Prado , kgene@kernel.org, javier@osg.samsung.com, linux@armlinux.org.uk, linux@simtec.co.uk, richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Sat, Oct 22, 2016 at 02:29:07PM +0200, Boris Brezillon wrote: > Hi Krzysztof, > > On Fri, 21 Oct 2016 21:27:10 +0300 > Krzysztof Kozlowski wrote: > > > On Thu, Oct 20, 2016 at 07:42:44PM -0200, Sergio Prado wrote: > > > Removing CONFIG_MTD_NAND_S3C2410_HWECC option and adding a ecc_mode > > > field in the drivers's platform data structure so it can be selectable > > > via platform data. > > > > > > Also setting this field to NAND_ECC_SOFT in all boards using this > > > driver since none of them had CONFIG_MTD_NAND_S3C2410_HWECC enabled. > > > > > > Signed-off-by: Sergio Prado > > > --- > > > arch/arm/mach-s3c24xx/common-smdk.c | 1 + > > > arch/arm/mach-s3c24xx/mach-anubis.c | 1 + > > > arch/arm/mach-s3c24xx/mach-at2440evb.c | 1 + > > > arch/arm/mach-s3c24xx/mach-bast.c | 1 + > > > arch/arm/mach-s3c24xx/mach-gta02.c | 1 + > > > arch/arm/mach-s3c24xx/mach-jive.c | 1 + > > > arch/arm/mach-s3c24xx/mach-mini2440.c | 1 + > > > arch/arm/mach-s3c24xx/mach-osiris.c | 1 + > > > arch/arm/mach-s3c24xx/mach-qt2410.c | 1 + > > > arch/arm/mach-s3c24xx/mach-rx1950.c | 1 + > > > arch/arm/mach-s3c24xx/mach-rx3715.c | 1 + > > > arch/arm/mach-s3c24xx/mach-vstms.c | 1 + > > > arch/arm/mach-s3c64xx/mach-hmt.c | 1 + > > > arch/arm/mach-s3c64xx/mach-mini6410.c | 1 + > > > arch/arm/mach-s3c64xx/mach-real6410.c | 1 + > > > drivers/mtd/nand/Kconfig | 9 -- > > > drivers/mtd/nand/s3c2410.c | 119 +++++++++++++------------ > > > include/linux/platform_data/mtd-nand-s3c2410.h | 6 +- > > > 18 files changed, 79 insertions(+), 70 deletions(-) > > > > > > > I acked this twice (v1 and v2)... and still you are ignoring them. I am > > sorry, I am not gonna to ack this third time! > > > > For v2 I acked also other patches but it it is not there as well... > > I'll collect your acks (and Rob ones) when applying the patches. BTW, > how should I proceed with patch 1? Do you want an topic branch > containing this patch? I don't expect much work around these files so the risk of conflicts is rather small. You could put it on a topic branch just in case (so I could pull in if needed) but I am fine with applying these to your tree as is. Best regards, Krzysztof