From: Mark Rutland <mark.rutland@arm.com>
To: Minghuan Lian <Minghuan.Lian@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Marc Zyngier <marc.zyngier@arm.com>,
Stuart Yoder <stuart.yoder@nxp.com>,
Yang-Leo Li <leoyang.li@nxp.com>, Scott Wood <scott.wood@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Mingkai Hu <mingkai.hu@nxp.com>
Subject: Re: [PATCH 3/6] arm64: dts: ls1043a: update MSI and PCIe node
Date: Wed, 26 Oct 2016 11:33:55 +0100 [thread overview]
Message-ID: <20161026103339.GD19965@leverpostej> (raw)
In-Reply-To: <1477398945-22774-3-git-send-email-Minghuan.Lian@nxp.com>
On Tue, Oct 25, 2016 at 08:35:42PM +0800, Minghuan Lian wrote:
> 3. The rev1.1 of LS1043a moves PCIe INTB/C/D interrupts to MSI controller.
[...]
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index 41e5dc1..5295bb9 100644
> - interrupt-map = <0000 0 0 1 &gic 0 110 0x4>,
> - <0000 0 0 2 &gic 0 111 0x4>,
> - <0000 0 0 3 &gic 0 112 0x4>,
> - <0000 0 0 4 &gic 0 113 0x4>;
> + interrupt-map = <0000 0 0 1 &gic 0 110 0x4>;
[...]
> - interrupt-map = <0000 0 0 1 &gic 0 120 0x4>,
> - <0000 0 0 2 &gic 0 121 0x4>,
> - <0000 0 0 3 &gic 0 122 0x4>,
> - <0000 0 0 4 &gic 0 123 0x4>;
> + interrupt-map = <0000 0 0 1 &gic 0 120 0x4>;
> };
[...]
> - interrupt-map = <0000 0 0 1 &gic 0 154 0x4>,
> - <0000 0 0 2 &gic 0 155 0x4>,
> - <0000 0 0 3 &gic 0 156 0x4>,
> - <0000 0 0 4 &gic 0 157 0x4>;
> + interrupt-map = <0000 0 0 1 &gic 0 154 0x4>;
Per the description above, this breaks revisions prior to 1.1.
Please, split the rev 1.1 changes into a new DTS. Share the common parts
in a common dtsi.
Thanks,
Mark.
next prev parent reply other threads:[~2016-10-26 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 12:35 [PATCH 1/6] dt/bindings: adjust bindings for Layerscape SCFG MSI Minghuan Lian
2016-10-25 12:35 ` [PATCH 2/6] arm: dts: ls1021a: update MSI node Minghuan Lian
[not found] ` <1477398945-22774-2-git-send-email-Minghuan.Lian-3arQi8VN3Tc@public.gmane.org>
2016-10-31 2:42 ` Rob Herring
2016-10-25 12:35 ` [PATCH 3/6] arm64: dts: ls1043a: update MSI and PCIe node Minghuan Lian
2016-10-26 10:33 ` Mark Rutland [this message]
2016-10-25 12:35 ` [PATCH 4/6] arm64: dts: ls1046a: add MSI dts node Minghuan Lian
2016-10-25 12:35 ` [PATCH 5/6] arm64: dts: ls1043a: update gic " Minghuan Lian
2016-10-26 10:35 ` Mark Rutland
2016-10-25 12:35 ` [PATCH 6/6] arm64: dts: ls1046a: add PCIe " Minghuan Lian
2016-10-25 13:01 ` [PATCH 1/6] dt/bindings: adjust bindings for Layerscape SCFG MSI Robin Murphy
2016-10-26 6:55 ` M.H. Lian
2016-10-26 10:22 ` Mark Rutland
2016-10-26 10:31 ` Mark Rutland
2016-10-26 22:09 ` Leo Li
2016-10-27 14:18 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026103339.GD19965@leverpostej \
--to=mark.rutland@arm.com \
--cc=Minghuan.Lian@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingkai.hu@nxp.com \
--cc=scott.wood@nxp.com \
--cc=shawnguo@kernel.org \
--cc=stuart.yoder@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).