* [PATCH] ARM: dts: socfpga: add specific compatible strings for boards
@ 2016-11-01 15:38 Dinh Nguyen
[not found] ` <20161101153817.6977-1-dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Dinh Nguyen @ 2016-11-01 15:38 UTC (permalink / raw)
To: devicetree-u79uwXL29TY76Z2rM5mHXA
Cc: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
olof-nZhT3qVonbNeoWH0uzbU5w,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Dinh Nguyen
Add a more specific board compatible entry for all of the SOCFPGA
Cyclone 5 based boards.
Signed-off-by: Dinh Nguyen <dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts | 2 +-
arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts | 2 +-
arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 2 +-
arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 2 +-
arch/arm/boot/dts/socfpga_cyclone5_sodia.dts | 2 +-
arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
index afea364..5ecd2ef 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
@@ -18,7 +18,7 @@
/ {
model = "Terasic DE-0(Atlas)";
- compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+ compatible = "terasic,de0-atlas", "altr,socfpga-cyclone5", "altr,socfpga";
chosen {
bootargs = "earlyprintk";
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts b/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts
index 424523b..668d77c 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts
@@ -19,7 +19,7 @@
/ {
model = "Aries/DENX MCV EVK";
- compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+ compatible = "denx, mcvevk", "altr,socfpga-cyclone5", "altr,socfpga";
aliases {
ethernet0 = &gmac0;
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
index 15e43f4..b0577c1 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
@@ -19,7 +19,7 @@
/ {
model = "Altera SOCFPGA Cyclone V SoC Development Kit";
- compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+ compatible = "altr,socdk", "altr,socfpga-cyclone5", "altr,socfpga";
chosen {
bootargs = "earlyprintk";
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
index 02e22f5..c5623a7 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
@@ -19,7 +19,7 @@
/ {
model = "Terasic SoCkit";
- compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+ compatible = "terasic,sockit", "altr,socfpga-cyclone5", "altr,socfpga";
chosen {
bootargs = "earlyprintk";
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
index 9aaf413..992ae49 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
@@ -21,7 +21,7 @@
/ {
model = "Altera SOCFPGA Cyclone V SoC Macnica Sodia board";
- compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+ compatible = "macnica, sodia", "altr,socfpga-cyclone5", "altr,socfpga";
chosen {
bootargs = "earlyprintk";
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
index b844473..78b187e 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
@@ -51,7 +51,7 @@
/ {
model = "samtec VIN|ING FPGA";
- compatible = "altr,socfpga-cyclone5", "altr,socfpga";
+ compatible = "samtec,vining". "altr,socfpga-cyclone5", "altr,socfpga";
chosen {
bootargs = "console=ttyS0,115200";
--
2.8.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20161101153817.6977-1-dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] ARM: dts: socfpga: add specific compatible strings for boards [not found] ` <20161101153817.6977-1-dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> @ 2016-11-01 20:10 ` Vladimir Zapolskiy [not found] ` <6ebcc3e9-37b7-7c27-a111-9fc663d07864-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Vladimir Zapolskiy @ 2016-11-01 20:10 UTC (permalink / raw) To: Dinh Nguyen, devicetree-u79uwXL29TY76Z2rM5mHXA Cc: dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, olof-nZhT3qVonbNeoWH0uzbU5w, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hi Dinh, On 11/01/2016 05:38 PM, Dinh Nguyen wrote: > Add a more specific board compatible entry for all of the SOCFPGA > Cyclone 5 based boards. > > Signed-off-by: Dinh Nguyen <dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > --- > arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts | 2 +- > arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts | 2 +- > arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 2 +- > arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 2 +- > arch/arm/boot/dts/socfpga_cyclone5_sodia.dts | 2 +- > arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts > index afea364..5ecd2ef 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts > @@ -18,7 +18,7 @@ > > / { > model = "Terasic DE-0(Atlas)"; > - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; > + compatible = "terasic,de0-atlas", "altr,socfpga-cyclone5", "altr,socfpga"; > > chosen { > bootargs = "earlyprintk"; > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts b/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts > index 424523b..668d77c 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts > @@ -19,7 +19,7 @@ > > / { > model = "Aries/DENX MCV EVK"; > - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; > + compatible = "denx, mcvevk", "altr,socfpga-cyclone5", "altr,socfpga"; Redundant space ^ > > aliases { > ethernet0 = &gmac0; > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > index 15e43f4..b0577c1 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > @@ -19,7 +19,7 @@ > > / { > model = "Altera SOCFPGA Cyclone V SoC Development Kit"; > - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; > + compatible = "altr,socdk", "altr,socfpga-cyclone5", "altr,socfpga"; > > chosen { > bootargs = "earlyprintk"; > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts > index 02e22f5..c5623a7 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts > @@ -19,7 +19,7 @@ > > / { > model = "Terasic SoCkit"; > - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; > + compatible = "terasic,sockit", "altr,socfpga-cyclone5", "altr,socfpga"; > > chosen { > bootargs = "earlyprintk"; > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts > index 9aaf413..992ae49 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts > @@ -21,7 +21,7 @@ > > / { > model = "Altera SOCFPGA Cyclone V SoC Macnica Sodia board"; > - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; > + compatible = "macnica, sodia", "altr,socfpga-cyclone5", "altr,socfpga"; Redundant space ^ If it is not yet done, you may consider to add Macnica to Documentation/devicetree/bindings/vendor-prefixes.txt > > chosen { > bootargs = "earlyprintk"; > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts > index b844473..78b187e 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts > @@ -51,7 +51,7 @@ > > / { > model = "samtec VIN|ING FPGA"; > - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; > + compatible = "samtec,vining". "altr,socfpga-cyclone5", "altr,socfpga"; Comma is expected here ^ Probably Terasic and Samtec are also not in the vendor-prefixes.txt list, usually checkpatch complains about it. > > chosen { > bootargs = "console=ttyS0,115200"; > -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <6ebcc3e9-37b7-7c27-a111-9fc663d07864-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] ARM: dts: socfpga: add specific compatible strings for boards [not found] ` <6ebcc3e9-37b7-7c27-a111-9fc663d07864-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org> @ 2016-11-01 20:13 ` Dinh Nguyen 0 siblings, 0 replies; 3+ messages in thread From: Dinh Nguyen @ 2016-11-01 20:13 UTC (permalink / raw) To: Vladimir Zapolskiy, Dinh Nguyen, devicetree-u79uwXL29TY76Z2rM5mHXA Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, olof-nZhT3qVonbNeoWH0uzbU5w, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hi Vladimir, On 11/01/2016 03:10 PM, Vladimir Zapolskiy wrote: > Hi Dinh, > > On 11/01/2016 05:38 PM, Dinh Nguyen wrote: >> Add a more specific board compatible entry for all of the SOCFPGA >> Cyclone 5 based boards. >> >> Signed-off-by: Dinh Nguyen <dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> --- >> arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts | 2 +- >> arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts | 2 +- >> arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 2 +- >> arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 2 +- >> arch/arm/boot/dts/socfpga_cyclone5_sodia.dts | 2 +- >> arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 2 +- >> 6 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts >> b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts >> index afea364..5ecd2ef 100644 >> --- a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts >> +++ b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts >> @@ -18,7 +18,7 @@ >> >> / { >> model = "Terasic DE-0(Atlas)"; >> - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; >> + compatible = "terasic,de0-atlas", "altr,socfpga-cyclone5", >> "altr,socfpga"; >> >> chosen { >> bootargs = "earlyprintk"; >> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts >> b/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts >> index 424523b..668d77c 100644 >> --- a/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts >> +++ b/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts >> @@ -19,7 +19,7 @@ >> >> / { >> model = "Aries/DENX MCV EVK"; >> - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; >> + compatible = "denx, mcvevk", "altr,socfpga-cyclone5", >> "altr,socfpga"; > > Redundant space ^ OK > >> >> aliases { >> ethernet0 = &gmac0; >> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts >> b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts >> index 15e43f4..b0577c1 100644 >> --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts >> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts >> @@ -19,7 +19,7 @@ >> >> / { >> model = "Altera SOCFPGA Cyclone V SoC Development Kit"; >> - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; >> + compatible = "altr,socdk", "altr,socfpga-cyclone5", "altr,socfpga"; >> >> chosen { >> bootargs = "earlyprintk"; >> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >> b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >> index 02e22f5..c5623a7 100644 >> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts >> @@ -19,7 +19,7 @@ >> >> / { >> model = "Terasic SoCkit"; >> - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; >> + compatible = "terasic,sockit", "altr,socfpga-cyclone5", >> "altr,socfpga"; >> >> chosen { >> bootargs = "earlyprintk"; >> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts >> b/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts >> index 9aaf413..992ae49 100644 >> --- a/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts >> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts >> @@ -21,7 +21,7 @@ >> >> / { >> model = "Altera SOCFPGA Cyclone V SoC Macnica Sodia board"; >> - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; >> + compatible = "macnica, sodia", "altr,socfpga-cyclone5", >> "altr,socfpga"; > > Redundant space ^ Ok, > > If it is not yet done, you may consider to add Macnica to > Documentation/devicetree/bindings/vendor-prefixes.txt > Yes, I have sent separate patches to add the vendor prefixes. >> >> chosen { >> bootargs = "earlyprintk"; >> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts >> b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts >> index b844473..78b187e 100644 >> --- a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts >> +++ b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts >> @@ -51,7 +51,7 @@ >> >> / { >> model = "samtec VIN|ING FPGA"; >> - compatible = "altr,socfpga-cyclone5", "altr,socfpga"; >> + compatible = "samtec,vining". "altr,socfpga-cyclone5", >> "altr,socfpga"; > > Comma is expected here ^ Ok, > > Probably Terasic and Samtec are also not in the vendor-prefixes.txt list, > usually checkpatch complains about it. Yes, I have sent patches for the vendor prefixes. Thanks for reviewing. Dinh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-01 20:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-01 15:38 [PATCH] ARM: dts: socfpga: add specific compatible strings for boards Dinh Nguyen
[not found] ` <20161101153817.6977-1-dinguyen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-11-01 20:10 ` Vladimir Zapolskiy
[not found] ` <6ebcc3e9-37b7-7c27-a111-9fc663d07864-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2016-11-01 20:13 ` Dinh Nguyen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).