From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] clk: cdce925: add support for CDCE913, CDCE937, and CDCE949 Date: Tue, 1 Nov 2016 10:48:08 -0700 Message-ID: <20161101174808.GU16026@codeaurora.org> References: <1477848637-5151-1-git-send-email-akinobu.mita@gmail.com> <20161031181509.GS16026@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Akinobu Mita Cc: linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "open list:OPEN FIRMWARE AND..." , Mike Looijmans , Michael Turquette List-Id: devicetree@vger.kernel.org On 11/01, Akinobu Mita wrote: > 2016-11-01 3:15 GMT+09:00 Stephen Boyd : > > On 10/31, Akinobu Mita wrote: > >> @@ -728,13 +780,19 @@ static int cdce925_probe(struct i2c_client *client, > >> } > >> > >> static const struct i2c_device_id cdce925_id[] = { > >> - { "cdce925", 0 }, > >> + { "cdce913", CDCE913 }, > >> + { "cdce925", CDCE925 }, > >> + { "cdce937", CDCE937 }, > >> + { "cdce949", CDCE949 }, > >> { } > >> }; > >> MODULE_DEVICE_TABLE(i2c, cdce925_id); > >> > >> static const struct of_device_id clk_cdce925_of_match[] = { > >> + { .compatible = "ti,cdce913" }, > >> { .compatible = "ti,cdce925" }, > >> + { .compatible = "ti,cdce937" }, > >> + { .compatible = "ti,cdce949" }, > > > > Doesn't this need to be updated to point to the correct enum > > values? > > I think it isn't needed. Because the data field in struct of_device_id > for this driver is not used even if the device is registered from > device tree. But the driver_data in i2c_device_id is used instead. Ok. Have you tested this driver with DT or platform data? Do you prefix the compatible string with "ti," in the DT case? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html