From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH v3 2/6] arm64: arch_timer: Introduce a generic erratum handing mechanism for fsl-a008585 Date: Fri, 4 Nov 2016 13:20:50 -0500 Message-ID: <20161104182050.GA1651@buserror.net> References: <1478264794-14652-1-git-send-email-dingtianhong@huawei.com> <1478264794-14652-2-git-send-email-dingtianhong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1478264794-14652-2-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ding Tianhong Cc: catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, stuart.yoder-3arQi8VN3Tc@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Nov 04, 2016 at 09:06:30PM +0800, Ding Tianhong wrote: > The workaround for hisilicon,161601 will check the return value of the system counter > by different way, in order to distinguish with the fsl-a008585 workaround, introduce > a new generic erratum handing mechanism for fsl-a008585 and rename some functions. > > v2: Introducing a new generic erratum handling mechanism for fsl erratum a008585. > > v3: Introducing the erratum_workaround_set_sne generic function for fsl erratum a008585 > and make the #define __fsl_a008585_read_reg to be private to the .c file instead of > being globally visible. After discussion with Marc and Will, a consensus decision was > made to remove the commandline parameter for enabling fsl,erratum-a008585 erratum, > and make some generic name more specific, export timer_unstable_counter_workaround > for module access. The command line paramter was added at Marc's request to provide a way of enbaling the workaround in a KVM guest, until API is added to allow QEMU to discover the need to set the property in the guest device tree. Is there an alternative? -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html