From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver Date: Sun, 6 Nov 2016 19:02:48 +0100 Message-ID: <20161106190248.48b59e166bcd9d6f0ebb4d04@free.fr> References: Reply-To: moinejf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Dave Airlie , Liam Girdwood , Mark Brown , Maxime Ripard , Rob Herring , Linux-ALSA , devicetree , dri-devel , linux-arm-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org On Sun, 23 Oct 2016 09:33:16 +0800 Chen-Yu Tsai wrote: > On Fri, Oct 21, 2016 at 4:36 PM, Jean-Francois Moine wr= ote: > > This patch adds I2S support to sun8i SoCs as the A83T and H3. > > > > Signed-off-by: Jean-Francois Moine > > --- > > Note: This driver is closed to the sun4i-i2s except that: > > - it handles the H3 >=20 > If it's close to sun4i-i2s, you should probably rework that one to suppor= t > the newer SoCs. I started to add the H3 into the sun4i-i2s, but I am blocked with regmap. Many H3 registers are common with the A10, but some of them have more or less fields, the fields may be at different offsets. And, finally, some registers are completely different. This would not raise any problem, except with regmap which is really painful. As I may understood, regmap is used to simplify suspend/resume, but, is it useful to save the I2S register on suspend? Practically, I am streaming some tune on my device. I suspend it for any reason. The next morning, I resume it. Are you sure I want to continue to hear the end of the tune? I better think that streaming should be simply stopped on suspend. Then, there is no need to save the playing registers, and, here I am, there is no need to use regmap. May I go this way? --=20 Ken ar c'henta=C3=B1 | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.