From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 6/6] ARM: dts: Extend the S3C RTC node with rtc_src clock Date: Mon, 7 Nov 2016 19:44:11 +0200 Message-ID: <20161107174411.GC4865@kozik-lap> References: <1478513376-14307-1-git-send-email-pankaj.dubey@samsung.com> <1478513376-14307-7-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1478513376-14307-7-git-send-email-pankaj.dubey@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Pankaj Dubey Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, krzk@kernel.org, javier@osg.samsung.com, kgene@kernel.org, thomas.ab@samsung.com, myungjoo.ham@samsung.com, Rob Herring , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Mon, Nov 07, 2016 at 03:39:36PM +0530, Pankaj Dubey wrote: > Extend the S3C RTC node with rtc_src clock so it could be operational. > The rtc_src clock is provided by MAX8997. > > CC: Rob Herring > CC: devicetree@vger.kernel.org > Signed-off-by: Pankaj Dubey > --- > arch/arm/boot/dts/exynos4210-origen.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts > index 6c7ef4e..4cac9b6 100644 > --- a/arch/arm/boot/dts/exynos4210-origen.dts > +++ b/arch/arm/boot/dts/exynos4210-origen.dts > @@ -18,6 +18,7 @@ > #include "exynos4210.dtsi" > #include > #include > +#include Just a nit: put the system-wide includes in alphabetical order, so clock, gpio and finally input. It helps reducing conflicting changes (when more people add includes in the same time). Beside that, looks good, but it requires a dt-bindings in separate patch so I could pull it. Best regards, Krzysztof