From: Rob Herring <robh@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"David S . Miller" <davem@davemloft.net>,
Mark Rutland <mark.rutland@arm.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
Maarten ter Huurne <maarten@treewalker.org>
Subject: Re: [PATCH 1/2] Documentation: devicetree: Add bindings info for rfkill-regulator
Date: Wed, 9 Nov 2016 12:26:12 -0600 [thread overview]
Message-ID: <20161109182612.i4rnsdxulk5ghemz@rob-hp-laptop> (raw)
In-Reply-To: <20161101105840.24313-1-paul@crapouillou.net>
On Tue, Nov 01, 2016 at 11:58:39AM +0100, Paul Cercueil wrote:
> This document gives information about how to write a devicetree
> node that corresponds to the rfkill-regulator driver.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> .../devicetree/bindings/net/rfkill-regulator.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/rfkill-regulator.txt
>
> diff --git a/Documentation/devicetree/bindings/net/rfkill-regulator.txt b/Documentation/devicetree/bindings/net/rfkill-regulator.txt
> new file mode 100644
> index 0000000..aac2fe1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/rfkill-regulator.txt
> @@ -0,0 +1,18 @@
> +Device tree bindings for the rfkill-regulator driver
> +
> +Required properties:
> + - compatible: should be "rfkill-regulator"
> + - rfkill-name: the name of this rfkill device
> + - rfkill-type: the type of this rfkill device;
> + must correspond to a valid rfkill_type from <uapi/linux/rfkill.h>
> + - vrfkill-supply: phandle to a regulator
My understanding is it is generally felt that using the regulator enable
GPIO commonly found on WiFi chips for rfkill is an abuse of rfkill as it
is more that just an RF disable. From a DT standpoint, this seems like
creating a binding for what a Linux driver wants. Instead, I think this
should be either a GPIO or GPIO regulator and the driver for the WiFi
chip should decide whether or not to register that as an rfkill driver.
Rob
next prev parent reply other threads:[~2016-11-09 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 10:58 [PATCH 1/2] Documentation: devicetree: Add bindings info for rfkill-regulator Paul Cercueil
2016-11-01 10:58 ` [PATCH 2/2] net: rfkill-regulator: Add devicetree support Paul Cercueil
2016-11-09 18:26 ` Rob Herring [this message]
2017-01-02 14:57 ` [PATCH 1/2] Documentation: devicetree: Add bindings info for rfkill-regulator Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109182612.i4rnsdxulk5ghemz@rob-hp-laptop \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maarten@treewalker.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox