From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/3] remoteproc: qcom: Encapsulate pvt data structure for q6v56 hexagon. Date: Thu, 10 Nov 2016 14:30:13 -0600 Message-ID: <20161110203013.fphvzd4df3zvjdfi@rob-hp-laptop> References: <1478268057-11847-1-git-send-email-akdwived@codeaurora.org> <1478268057-11847-2-git-send-email-akdwived@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1478268057-11847-2-git-send-email-akdwived-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Avaneesh Kumar Dwivedi Cc: bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Ohad Ben-Cohen , Mark Rutland , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org On Fri, Nov 04, 2016 at 07:30:54PM +0530, Avaneesh Kumar Dwivedi wrote: > Encapsulate resources specific to each version of hexagon chip to > device node to avoid conditional check for manipulation of those > resources in driver code. > > Signed-off-by: Avaneesh Kumar Dwivedi > --- > .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 1 + > drivers/remoteproc/qcom_q6v5_pil.c | 137 ++++++++++++++++++--- > 2 files changed, 120 insertions(+), 18 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > index 57cb49e..cbc165c 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > @@ -8,6 +8,7 @@ on the Qualcomm Hexagon core. > Value type: > Definition: must be one of: > "qcom,q6v5-pil" > + "qcom,q6v56-pil" Perhaps some explanation in the commit message about what these magic numbers mean? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html