From: Tejun Heo <tj@kernel.org>
To: Rameshwar Sahu <rsahu@apm.com>
Cc: Olof Johansson <olof@lixom.net>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Devicetree List <devicetree@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Don Dutile <ddutile@redhat.com>, Jon Masters <jcm@redhat.com>,
patches <patches@apm.com>
Subject: Re: [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1
Date: Tue, 15 Nov 2016 11:21:18 -0500 [thread overview]
Message-ID: <20161115162118.GA30547@htj.duckdns.org> (raw)
In-Reply-To: <CAFd313ycmpdp7wHCVRJrigJV31hLwBGOo=FNENwgFnNKyVkQBA@mail.gmail.com>
Hello, Rameshwar.
On Fri, Nov 11, 2016 at 01:36:28PM +0530, Rameshwar Sahu wrote:
> Hi Tejun,
>
> On Wed, Nov 9, 2016 at 10:15 PM, Tejun Heo <tj@kernel.org> wrote:
> > Hello,
> >
> > On Wed, Sep 14, 2016 at 04:15:00PM +0530, Rameshwar Sahu wrote:
> >> > @@ -821,8 +823,6 @@ static int xgene_ahci_probe(struct platform_device
> >> > *pdev)
> >> > dev_warn(&pdev->dev, "%s: Error reading
> >> > device info. Assume version1\n",
> >> > __func__);
> >> > version = XGENE_AHCI_V1;
> >> > - } else if (info->valid & ACPI_VALID_CID) {
> >> > - version = XGENE_AHCI_V2;
> >
> > Can you please explain this part a bit? Everything else looks good to
> > me.
>
> Here we should not assume XGENE_AHCI_V2 always in case of having valid
> _CID in ACPI table.
> I need to remove this assumption because V1_1 has also valid _CID for
> backward compatibly with v1.
Can you please repost with the above explanation added to the commit
message?
Thanks!
--
tejun
next prev parent reply other threads:[~2016-11-15 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 9:20 [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1 Rameshwar Prasad Sahu
[not found] ` <CAFd313x-mXpy0N3aKx2rfoag1FNOrN-LzKb5UHkY2L+GGc0B-A@mail.gmail.com>
2016-11-09 16:45 ` Tejun Heo
[not found] ` <20161109164531.GA14630-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-11-11 8:06 ` Rameshwar Sahu
2016-11-15 16:21 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-20 11:14 Rameshwar Prasad Sahu
2016-11-09 11:39 ` Rameshwar Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115162118.GA30547@htj.duckdns.org \
--to=tj@kernel.org \
--cc=ddutile@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=rsahu@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).