From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options Date: Wed, 16 Nov 2016 14:23:37 +0100 Message-ID: <20161116132337.GD19962@lunn.ch> References: <1479220154-25851-1-git-send-email-jbrunet@baylibre.com> <1479220154-25851-2-git-send-email-jbrunet@baylibre.com> <20161115163036.GB23231@lunn.ch> <476b72f3-5efe-3551-6c24-0e378d655a0f@gmail.com> <1479290189.17538.25.camel@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1479290189.17538.25.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jerome Brunet Cc: Florian Fainelli , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Carlo Caione , Kevin Hilman , Giuseppe Cavallaro , Alexandre TORGUE , Martin Blumenstingl , Andre Roth , Neil Armstrong , linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org > There two kind of PHYs supporting eee, the one advertising eee by > default (like realtek) and the one not advertising it (like micrel). I don't know too much about EEE. So maybe a dumb question. Does the MAC need to be involved? Or is it just the PHY? If the MAC needs to be involved, the PHY should not be advertising EEE unless the MAC asks for it by calling phy_init_eee(). If this is true, maybe we need to change the realtek driver, and others in that class. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html