Re: [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver

Maxime Ripard
2016-10-24T12:34:49Z

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

Hi,

On Sun, Oct 23, 2016 at 09:45:03AM +0200, Jean-Francois Moine wrote:
> On Sun, 23 Oct 2016 09:33:16 +0800
> Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> wrote:
>
> > > Note: This driver is closed to the sun4i-i2s except that:
> > > - it handles the H3
> >
> > If it's close to sun4i-i2s, you should probably rework that one to support
> > the newer SoCs.
> >
> > > - it creates the sound card (with sun4i-i2s, the sound card is created
> > > by the CODECs)
> >
> > I think this is wrong. I2S is only the DAI. You typically have a separate
> > platform driver for the whole card, or just use simple-card.
>
> An other device is not needed. The layout is simple:
> I2S_controller (CPU DAI) <-> HDMI_CODEC (CODEC DAI)
> The HDMI CODEC is supported by the HDMI video driver (only one device),
> so, it cannot be the card device.
> ASoC does not use the CPU DAI device (I2S_controller), so, it is
> natural to use it to handle the card.

Still, duplicating the driver is not the solution. I agree with
Chen-Yu that we want to leverage the driver that is already there.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering