Re: [PATCH v5 3/7] drm: sunxi: add DE2 HDMI support

Maxime Ripard
2016-10-24T13:17:03Z

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi,

On Fri, Oct 21, 2016 at 10:08:06AM +0200, Jean-Francois Moine wrote:
> This patch adds a HDMI driver to the DE2 based Allwinner's SoCs
> as A83T and H3.
> Audio and video are supported.
>
> Signed-off-by: Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>

Output from checkpatch:
total: 26 errors, 31 warnings, 70 checks, 1458 lines checked

Please run checkpatch before sending your patches.

Apart from that, this looks an awful lot like the designware HDMI
controller, for which a driver already exists. Any reason to create a
new driver from scratch?

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering