From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins Date: Thu, 17 Nov 2016 21:40:43 +0100 Message-ID: <20161117204043.wz66gpsb4y2pt7yu@lukather> References: <20161117093438.17988-1-wens@csie.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iw4zlf3tz5you664" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20161117093438.17988-1-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Linus Walleij , Klaus Goger , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --iw4zlf3tz5you664 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Thu, Nov 17, 2016 at 05:34:38PM +0800, Chen-Yu Tsai wrote: > In the past, all the MMC pins had > > allwinner,pull = ; > > which was actually a no-op. We were relying on U-boot to set the bias > pull up for us. These properties were removed as part of the fix up to > actually support no bias on the pins. During the transition some boards > experienced regular MMC time-outs during normal operation, while others > completely failed to initialize the SD card. > > Given that MMC starts in open-drain mode and the pull-ups are required, > it's best to enable it for all the pin settings. > > Signed-off-by: Chen-Yu Tsai Applied, thanks. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --iw4zlf3tz5you664--