From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v3 06/13] ARM: dts: armada-375: Fixup sa-ram DT warning
Date: Fri, 18 Nov 2016 14:35:51 +0100 [thread overview]
Message-ID: <20161118143551.3a067bd0@free-electrons.com> (raw)
In-Reply-To: <8737ipat6u.fsf@free-electrons.com>
Hello,
On Fri, 18 Nov 2016 13:06:17 +0100, Gregory CLEMENT wrote:
> > But do we really want this comment above each node? Couldn't we instead
> > add this explanation in the mvebu-mbus.txt DT binding?
>
> We could but I fear that nobody will read it.
>
> Indeed if you know that in order to understand the unit address, you will
> have to have a look an the binding of the mvebu-mbus, then it means that
> you already are an expert and actually you barely need to read it!
Well, you anyway need to read the DT binding if you want to add more
nodes that use this magic MBUS_ID() thing, so I believe it makes sense
to have this comment in the binding documentation.
> In order to have less change we could at least put it near the MBUS_ID
> macro and if the mvebu-mbus.txt DT binding too.
Fine with that.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-18 13:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 23:08 [PATCH v3 00/13] Various Armada 375 DT warning fixup Gregory CLEMENT
[not found] ` <20161117230830.31047-1-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-17 23:08 ` [PATCH v3 01/13] ARM: dts: armada-375: Add node labels Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 02/13] ARM: dts: armada-375: Use the " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 03/13] ARM: dts: armada-375: Fixup mdio DT warning Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 04/13] ARM: dts: armada-375: Fixup bootrom " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 05/13] ARM: dts: armada-375: Fixup devbus " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 06/13] ARM: dts: armada-375: Fixup sa-ram " Gregory CLEMENT
[not found] ` <20161117230830.31047-7-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-18 8:59 ` Thomas Petazzoni
[not found] ` <20161118095925.770496c3-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-18 12:06 ` Gregory CLEMENT
2016-11-18 13:35 ` Thomas Petazzoni [this message]
2016-11-17 23:08 ` [PATCH v3 07/13] ARM: dts: armada-375: Fixup pcie DT warnings Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 08/13] ARM: dts: armada-375: Fixup pinctrl " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 09/13] ARM: dts: armada-375: Fixup soc DT warning Gregory CLEMENT
[not found] ` <20161117230830.31047-10-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-18 8:54 ` Thomas Petazzoni
[not found] ` <20161118095455.00bfe007-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-18 9:01 ` Gregory CLEMENT
[not found] ` <87d1htb1qr.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-18 9:12 ` Thomas Petazzoni
[not found] ` <20161118101248.784eff2b-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-18 9:38 ` Gregory CLEMENT
[not found] ` <877f81b013.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-18 13:38 ` Thomas Petazzoni
2016-11-17 23:08 ` [PATCH v3 10/13] ARM: dts: armada-375: Fixup internal-regs " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 11/13] ARM: dts: armada-375: Remove skeleton.dtsi Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 12/13] ARM: dts: armada-375: Fixup memory DT warning Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 13/13] ARM: dts: armada-375: Fixup ethernet child " Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118143551.3a067bd0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).