From: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Sekhar Nori" <nsekhar-l0cyMroinI0@public.gmane.org>,
"Axel Haslam" <ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Bartosz Gołaszewski"
<bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Alexandre Bailon"
<abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"David Lechner" <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
Subject: [PATCH v3 2/4] [media] davinci: vpif_capture: don't lock over s_stream
Date: Tue, 22 Nov 2016 07:52:42 -0800 [thread overview]
Message-ID: <20161122155244.802-3-khilman@baylibre.com> (raw)
In-Reply-To: <20161122155244.802-1-khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Video capture subdevs may be over I2C and may sleep during xfer, so we
cannot do IRQ-disabled locking when calling the subdev.
Signed-off-by: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
drivers/media/platform/davinci/vpif_capture.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c
index 87ee1e2c3864..94ee6cf03f02 100644
--- a/drivers/media/platform/davinci/vpif_capture.c
+++ b/drivers/media/platform/davinci/vpif_capture.c
@@ -193,7 +193,10 @@ static int vpif_start_streaming(struct vb2_queue *vq, unsigned int count)
}
}
+ spin_unlock_irqrestore(&common->irqlock, flags);
ret = v4l2_subdev_call(ch->sd, video, s_stream, 1);
+ spin_lock_irqsave(&common->irqlock, flags);
+
if (ret && ret != -ENOIOCTLCMD && ret != -ENODEV) {
vpif_dbg(1, debug, "stream on failed in subdev\n");
goto err;
--
2.9.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-22 15:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 15:52 [PATCH v3 0/4] [media] davinci: VPIF: add DT support Kevin Hilman
[not found] ` <20161122155244.802-1-khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-11-22 15:52 ` [PATCH v3 1/4] [media] davinci: add support for DT init Kevin Hilman
2016-11-22 15:52 ` Kevin Hilman [this message]
2016-11-22 15:52 ` [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT Kevin Hilman
[not found] ` <20161122155244.802-4-khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-11-23 15:37 ` Sakari Ailus
[not found] ` <20161123153723.GE16630-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2016-11-23 23:25 ` Kevin Hilman
[not found] ` <m2a8cpvkwj.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-11-30 22:51 ` Sakari Ailus
[not found] ` <20161130225136.GO16630-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2016-12-01 0:14 ` Kevin Hilman
[not found] ` <m2zikgh5f0.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-12-01 7:57 ` Sakari Ailus
[not found] ` <20161201075730.GP16630-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2016-12-01 9:16 ` Laurent Pinchart
2016-12-05 12:27 ` Hans Verkuil
[not found] ` <d7aaa1d5-f11a-e361-b2fe-f0cf86d92008-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2016-12-06 17:40 ` Kevin Hilman
[not found] ` <m2mvg9ez2h.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-12-06 19:50 ` Kevin Hilman
2016-12-07 14:09 ` Sakari Ailus
2016-11-23 23:26 ` Kevin Hilman
2016-11-22 15:52 ` [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation Kevin Hilman
[not found] ` <20161122155244.802-5-khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-11-28 21:38 ` Rob Herring
2016-11-28 22:16 ` Kevin Hilman
2016-11-28 22:30 ` Kevin Hilman
[not found] ` <m2shqbs0eu.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-11-29 14:41 ` Rob Herring
[not found] ` <CAL_JsqJ3wJnNa=bVN+UT4A-J5XC0jdyGAgWzROScRDLy6T8xHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-30 21:48 ` Sakari Ailus
[not found] ` <20161130214835.GN16630-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2016-11-30 23:48 ` Kevin Hilman
[not found] ` <m27f7kil5o.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-12-01 8:01 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122155244.802-3-khilman@baylibre.com \
--to=khilman-rdvid1duhrbwk0htik3j/w@public.gmane.org \
--cc=abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).