From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Rafael Wysocki <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
Viresh Kumar <vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vincent Guittot
<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
d-gerlach-l0cyMroinI0@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V6 08/10] PM / OPP: Allow platform specific custom set_opp() callbacks
Date: Thu, 1 Dec 2016 05:57:59 +0530 [thread overview]
Message-ID: <20161201002759.GP3288@vireshk-i7> (raw)
In-Reply-To: <20161130220419.GL6095-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On 30-11-16, 14:04, Stephen Boyd wrote:
> On 11/30, Viresh Kumar wrote:
> > The generic set_opp() handler isn't sufficient for platforms with
> > complex DVFS. For example, some TI platforms have multiple regulators
> > for a CPU device. The order in which various supplies need to be
> > programmed is only known to the platform code and its best to leave it
> > to it.
> >
> > This patch implements APIs to register platform specific set_opp()
> > callback.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > Tested-by: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>
> >
> > ---
>
> Reviewed-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Thanks.
> So this one has the same set/put problem the other APIs has?
Yes.
> Presumably we're going to need to fix and change the API that is
> introduced here. Wouldn't it be better to do that first though?
Returning opp_table is one of the solutions and I am not sure if it is
the best one. I am working on the cleanup series and will modify all
the routine the same way very soon.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-01 0:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 5:14 [PATCH V6 00/10] PM / OPP: Multiple regulator support Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 02/10] PM / OPP: Reword binding supporting multiple regulators per device Viresh Kumar
[not found] ` <cover.1480481312.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-30 5:14 ` [PATCH V6 01/10] PM / OPP: Fix incorrect cpu-supply property in binding Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 03/10] PM / OPP: Don't use OPP structure outside of rcu protected section Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 06/10] PM / OPP: Add infrastructure to manage multiple regulators Viresh Kumar
[not found] ` <3b3ce1dac198fb668b97e81490bcbcf03d31e40d.1480481312.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-30 22:37 ` Stephen Boyd
2016-12-01 0:51 ` Viresh Kumar
2016-12-01 10:59 ` Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 08/10] PM / OPP: Allow platform specific custom set_opp() callbacks Viresh Kumar
2016-11-30 22:04 ` Stephen Boyd
[not found] ` <20161130220419.GL6095-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-12-01 0:27 ` Viresh Kumar [this message]
2016-11-30 5:14 ` [PATCH V6 09/10] PM / OPP: Don't WARN on multiple calls to dev_pm_opp_set_regulators() Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 10/10] PM / OPP: Don't assume platform doesn't have regulators Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 04/10] PM / OPP: Manage supply's voltage/current in a separate structure Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 05/10] PM / OPP: Pass struct dev_pm_opp_supply to _set_opp_voltage() Viresh Kumar
2016-11-30 5:14 ` [PATCH V6 07/10] PM / OPP: Separate out _generic_set_opp() Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201002759.GP3288@vireshk-i7 \
--to=viresh.kumar-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=d-gerlach-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).