From: Anatolij Gustschin <agust@denx.de>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Moritz Fischer <moritz.fischer@ettus.com>,
devicetree@vger.kernel.org,
Alan Tull <atull@opensource.altera.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/3] lib: add bitrev8x4()
Date: Thu, 1 Dec 2016 23:45:23 +0100 [thread overview]
Message-ID: <20161201234523.3bed63dc@crub> (raw)
In-Reply-To: <bc92eb1507448731163ae67fc888668d327f9168.1480551148.git.stillcompiling@gmail.com>
On Thu, 1 Dec 2016 09:04:50 -0800
Joshua Clayton stillcompiling@gmail.com wrote:
...
>diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h
>index ec291c3..6d2e9ca 100644
>--- a/arch/arm/include/asm/bitrev.h
>+++ b/arch/arm/include/asm/bitrev.h
>@@ -17,4 +17,9 @@ static __always_inline __attribute_const__ u8 __arch_bitrev8(u8 x)
> return __arch_bitrev32((u32)x) >> 24;
> }
>
>+static __always_inline __attribute_const__ u32 __arch_bitrev8x4(u32 x)
>+{
>+ __asm__ ("rbit %0, %1; rev %0, %0" : "=r" (x) : "r" (x));
return x;
>+}
otherwise you get
In function '__arch_bitrev8x4':
warning: no return statement in function returning non-void [-Wreturn-type]
--
Anatolij
next prev parent reply other threads:[~2016-12-01 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 17:04 [PATCH v4 0/3] Altera Cyclone Passive Serial SPI FPGA Manager Joshua Clayton
2016-12-01 17:04 ` [PATCH v4 1/3] lib: add bitrev8x4() Joshua Clayton
2016-12-01 22:45 ` Anatolij Gustschin [this message]
2016-12-02 0:04 ` Joshua Clayton
[not found] ` <8fb2f1c2-c39c-b74f-d5c8-d6731cbd67c8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-02 7:51 ` Anatolij Gustschin
2016-12-01 17:04 ` [PATCH v4 2/3] doc: dt: add cyclone-spi binding document Joshua Clayton
[not found] ` <137f03de76e5f865430b17ca247e8f73e3315c8d.1480551148.git.stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-01 17:41 ` Moritz Fischer
2016-12-06 16:05 ` Rob Herring
2016-12-01 17:04 ` [PATCH v4 3/3] fpga manager: Add cyclone-ps-spi driver for Altera FPGAs Joshua Clayton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201234523.3bed63dc@crub \
--to=agust@denx.de \
--cc=atull@opensource.altera.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
--cc=stillcompiling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).