From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Subject: Re: [PATCH v4 1/3] lib: add bitrev8x4() Date: Thu, 1 Dec 2016 23:45:23 +0100 Message-ID: <20161201234523.3bed63dc@crub> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joshua Clayton Cc: Mark Rutland , Moritz Fischer , devicetree@vger.kernel.org, Alan Tull , Russell King , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thu, 1 Dec 2016 09:04:50 -0800 Joshua Clayton stillcompiling@gmail.com wrote: ... >diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h >index ec291c3..6d2e9ca 100644 >--- a/arch/arm/include/asm/bitrev.h >+++ b/arch/arm/include/asm/bitrev.h >@@ -17,4 +17,9 @@ static __always_inline __attribute_const__ u8 __arch_bitrev8(u8 x) > return __arch_bitrev32((u32)x) >> 24; > } > >+static __always_inline __attribute_const__ u32 __arch_bitrev8x4(u32 x) >+{ >+ __asm__ ("rbit %0, %1; rev %0, %0" : "=r" (x) : "r" (x)); return x; >+} otherwise you get In function '__arch_bitrev8x4': warning: no return statement in function returning non-void [-Wreturn-type] -- Anatolij