From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: omap3: beagleboard-xm: dt: Add ethernet to the device tree Date: Fri, 2 Dec 2016 08:53:24 -0800 Message-ID: <20161202165323.GC4705@atomide.com> References: <1480528685-26259-1-git-send-email-laurent.pinchart@ideasonboard.com> <20161202011807.GF3703@atomide.com> <4245212.aFfvVGINdT@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4245212.aFfvVGINdT@avalon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurent Pinchart Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?utf-8?Q?Beno=C3=AEt?= Cousson List-Id: devicetree@vger.kernel.org * Laurent Pinchart [161202 05:38]: > Hi Tony, > > On Thursday 01 Dec 2016 17:18:08 Tony Lindgren wrote: > > * Laurent Pinchart [161130 09:58]: > > > &usbhsehci { > > > > > > phys = <0 &hsusb2_phy>; > > > > > > + > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + usb2@2 { > > > > I think this should be usb1@2 instead of usb2@2? That's because it's > > at /sys/bus/usb/devices/1-2 and not at /sys/bus/usb/devices/2-2? > > > > Or what's the naming standard here? > > Good question. As far as I know, the node name is irrelevant, only the reg > value is important. Maybe we should call it hub@2 ? Yeah hub sounds good to me, Rob? Sohow does the kernel know which instance it is if there are multiple devices? For example, below is a patch for igepv5 (not yet using "hub" naming), note how it has things at 3-2 and 3-2.3. So if it also had something at 1-2 and 1-2.1, how would we name them? Regards, Tony 8< ------------------------ >>From tony Mon Sep 17 00:00:00 2001 From: Tony Lindgren Date: Thu, 1 Dec 2016 17:04:50 -0800 Subject: [PATCH] ARM: dts: omap5-igep0050: Allow bootloader to configure USB Ethernet MAC This is slightly different wiring compared to omap5-uevm or pandaboard: /sys/bus/usb/devices/3-2 hub /sys/bus/usb/devices/3-2.3 7500 Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/omap5-igep0050.dts | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts --- a/arch/arm/boot/dts/omap5-igep0050.dts +++ b/arch/arm/boot/dts/omap5-igep0050.dts @@ -19,6 +19,10 @@ reg = <0x0 0x80000000 0 0x7f000000>; /* 2032 MB */ }; + aliases { + ethernet = ðernet; + }; + gpio_keys { compatible = "gpio-keys"; pinctrl-0 = <&power_button_pin>; @@ -116,3 +120,20 @@ OMAP5_IOPAD(0x1ca, PIN_OUTPUT | MUX_MODE6) /* perslimbus2_clock.gpio5_145 */ >; }; + +&usbhsehci { + #address-cells = <1>; + #size-cells = <0>; + + usb3@2 { + compatible = "usb424,3503"; + reg = <2>; + #address-cells = <1>; + #size-cells = <0>; + + ethernet: usbether@3 { + compatible = "usb424,7500"; + reg = <3>; + }; + }; +}; -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html