From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH 1/2] devicetree: i2c-hid: Add regulator support Date: Mon, 5 Dec 2016 10:08:13 +0100 Message-ID: <20161205090813.GL1280@mail.corp.redhat.com> References: <1480717140-14558-1-git-send-email-briannorris@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1480717140-14558-1-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Brian Norris Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dmitry Torokhov , Jiri Kosina , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Caesar Wang List-Id: devicetree@vger.kernel.org On Dec 02 2016 or thereabouts, Brian Norris wrote: > From: Caesar Wang > > Document a "vdd-supply" and an initialization delay. Can be used for > powering on/off a HID. > > Signed-off-by: Caesar Wang > Cc: Rob Herring > Cc: Jiri Kosina > Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Brian Norris > --- > v2: > * add compatible property for wacom, per Rob's request > * name the regulator property specifically (VDD) > > v3: > * remove wacom property, per Benjamin's request > * add delay property > > v4: no change > --- > Documentation/devicetree/bindings/input/hid-over-i2c.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt > index 488edcb264c4..1ea290167652 100644 > --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt > +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt > @@ -17,6 +17,11 @@ Required properties: > - interrupt-parent: the phandle for the interrupt controller > - interrupts: interrupt line > > +Optional properties: > +- vdd-supply: phandle of the regulator that provides the supply voltage. > +- init-delay-ms: time required by the device after power-on before it is ready > + for communication. Nitpick: maybe we should say that the power-on applies to the vdd-supply parameter, not the SET_POWER HID command. I am just worried people will misuse this parameter. Otherwise, Acked-by: Benjamin Tissoires > + > Example: > > i2c-hid-dev@2c { > -- > 2.8.0.rc3.226.g39d4020 >