From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment Date: Wed, 7 Dec 2016 12:53:14 -0800 Message-ID: <20161207205314.GA20203@localhost> References: <20161123004204.10851-1-stefan@agner.ch> <7e4829f484f6c4425fc9d01bea1a094f@agner.ch> <20161205020123.GA2066@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161205020123.GA2066@dragon> Sender: linux-kernel-owner@vger.kernel.org To: Shawn Guo Cc: Arnd Bergmann , Sascha Hauer , Stefan Agner , Mark Rutland , devicetree@vger.kernel.org, linux-kernel , robh+dt@kernel.org, Peter Chen , Fabio Estevam , Liu Ying , linux-arm-kernel@lists.infradead.org, Fabio Estevam List-Id: devicetree@vger.kernel.org On Mon, Dec 05, 2016 at 10:01:24AM +0800, Shawn Guo wrote: > Hi Arnd, Olof, > > On Sun, Dec 04, 2016 at 05:26:58PM -0800, Stefan Agner wrote: > > Hi Shawn > > > > On 2016-11-23 15:02, Fabio Estevam wrote: > > > On Tue, Nov 22, 2016 at 10:42 PM, Stefan Agner wrote: > > >> The eLCDIF IP of the i.MX 7 SoC knows multiple clocks and lists them > > >> separately: > > >> > > >> Clock Clock Root Description > > >> apb_clk MAIN_AXI_CLK_ROOT AXI clock > > >> pix_clk LCDIF_PIXEL_CLK_ROOT Pixel clock > > >> ipg_clk_s MAIN_AXI_CLK_ROOT Peripheral access clock > > >> > > >> All of them are switched by a single gate, which is part of the > > >> IMX7D_LCDIF_PIXEL_ROOT_CLK clock. Hence using that clock also for > > >> the AXI bus clock (clock-name "axi") makes sure the gate gets > > >> enabled when accessing registers. > > >> > > >> There seem to be no separate AXI display clock, and the clock is > > >> optional. Hence remove the dummy clock. > > >> > > >> This fixes kernel freezes when starting the X-Server (which > > >> disables/re-enables the display controller). > > >> > > >> Signed-off-by: Stefan Agner > > > > > > Reviewed-by: Fabio Estevam > > > > Since this fixes a kernel freeze, is there a chance to get this still in > > 4.9? > > Since we get one more week to the final 4.9, is it possible for you to > send this fix for 4.9 inclusion? Thanks. > > For the patch, > > Acked-by: Shawn Guo Applied, with the fixes line. In the future, please email arm@kernel.org too, it's easier to make sure we don't miss it that way. -Olof