devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Kachalov Anton <mouse-Pma6HLj0uuo@public.gmane.org>
Cc: Brendan Higgins
	<brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org"
	<vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>,
	"clg-Bxea+6Xhats@public.gmane.org"
	<clg-Bxea+6Xhats@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"mark.rutland-5wv7dgnIgG8@public.gmane.org"
	<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org"
	<joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>,
	"openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH v5 1/2] i2c: aspeed: added driver for Aspeed I2C
Date: Mon, 12 Dec 2016 12:10:05 +0100	[thread overview]
Message-ID: <20161212111005.GA1450@katana> (raw)
In-Reply-To: <825541481540788-Mr5SgJCofHtxpj1cXAZ9Bg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]


> >>  + /* Switch from master mode to slave mode. */
> >>  + func_ctrl_reg_val = aspeed_i2c_read(bus, ASPEED_I2C_FUN_CTRL_REG);
> >>  + func_ctrl_reg_val &= ~ASPEED_I2CD_MASTER_EN;
> >>  + func_ctrl_reg_val |= ASPEED_I2CD_SLAVE_EN;
> >>  + aspeed_i2c_write(bus, func_ctrl_reg_val, ASPEED_I2C_FUN_CTRL_REG);
> >
> > Can't the hardware work both as master and slave on the same bus?
> 
> The hardware can work as master and slave on the same bus. This is how IPMB over i2c works on Aspeed.

Thanks! Then the driver should support this. Maybe it is an idea to
first upstream the master support and add the slave support
incrementally?

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-12-12 11:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30  1:00 [PATCH v5 0/2] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2016-11-30  1:00 ` [PATCH v5 1/2] " Brendan Higgins
     [not found]   ` <1480467618-7497-2-git-send-email-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-12-07  0:57     ` Vladimir Zapolskiy
2017-03-28  5:22       ` Brendan Higgins
2016-12-11 22:26   ` Wolfram Sang
2016-12-12 11:06     ` Kachalov Anton
     [not found]       ` <825541481540788-Mr5SgJCofHtxpj1cXAZ9Bg@public.gmane.org>
2016-12-12 11:10         ` Wolfram Sang [this message]
2017-03-28  5:23           ` Brendan Higgins
     [not found] ` <1480467618-7497-1-git-send-email-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-11-30  1:00   ` [PATCH v5 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins
2016-12-05 22:28     ` Rob Herring
     [not found]     ` <1480467618-7497-3-git-send-email-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-12-07  0:19       ` Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161212111005.GA1450@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=clg-Bxea+6Xhats@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mouse-Pma6HLj0uuo@public.gmane.org \
    --cc=openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).