devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Brian Norris <briannorris@chromium.org>,
	Javier Martinez Canillas <javier@dowhile0.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 4/4] regulator: Prevent falling too fast
Date: Tue, 13 Dec 2016 15:14:52 -0800	[thread overview]
Message-ID: <20161213231452.GB96889@google.com> (raw)
In-Reply-To: <CAD=FV=WhUVeq5GZ5-ae4SxypHGB9jWqgvkO02S=G6Zz6cexRzQ@mail.gmail.com>

Hi,

El Tue, Dec 13, 2016 at 12:00:32PM -0800 Doug Anderson ha dit:

> On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown <broonie@kernel.org> wrote:
> > On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote:
> >> El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit:
> >> > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote:
> >
> >> > What you're describing to me is a discrete DCDC that has an input
> >> > voltage that sets the output voltage which happens to be set with a PWM.
> >
> >> I experimented a bit with this. Besides the question of how to model
> >> the passives I wonder how the two regulators would interact. The
> >> correct thing seems to be to specify the input regulator as a supply
> >> of the DCDC. dcdc->set_voltage breaks down a voltage transition into
> >
> > No, not unless the prior descriptions of the hardware have been wildly
> > inaccurate - my understanding had been that the DCDC was a normal DCDC
> > with an analogue input intended to be biased to set the output voltage
> > (presumably in terms of a full rail supply) and that the PWM had been
> > connected to this analogue input.  If the PWM is supplying the DCDC then
> > the hardware design just seems bizzare, I can't see how this would even
> > work.
> 
> Looking at one schematic, the discrete BUCK for at least one of the
> rails is TPS65261RHBR, which appears to be described at
> <https://store.ti.com/TPS65261RHBR.aspx>.  Data sheet appears to be at
> <http://www.ti.com/product/tps65261/technicaldocuments?HQS=TI-null-null-octopart-df-pf-null-wwe>.
> 
> As you can see from the datasheet ("Adjusting the Output Voltage"
> section), it is intended that you stuff a resistor to make a voltage
> divider and that's how you select the output voltage.  In our case the
> PWM interacts here and allows you to make a more dynamic output
> voltage.  I've always thought about the input to the "FB" pin as
> making an input voltage, but I guess it's not terribly simple since
> the voltage divider ends up dividing between ground and the output
> voltage.

I also had put my mind on seeing the output of the PWM circuitry as an
input voltage, but technically it isn't a supply of the buck
regulator. It seems we could consider it a "control voltage" instead
and thus avoid the recursive lock acquisition.

Matthias

  reply	other threads:[~2016-12-13 23:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 19:05 [PATCH v4 4/4] regulator: Prevent falling too fast Matthias Kaehlcke
     [not found] ` <20160906190524.GB79728-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-12 18:56   ` Mark Brown
     [not found]     ` <20160912185633.GH27946-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-13 17:21       ` Matthias Kaehlcke
     [not found]         ` <20160913172140.GC62872-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-15 14:39           ` Mark Brown
     [not found]             ` <20160915143945.GJ27974-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-15 18:02               ` Matthias Kaehlcke
     [not found]                 ` <20160915180223.GE62872-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-16 16:32                   ` Mark Brown
     [not found]                     ` <20160916163253.GA10189-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-16 18:31                       ` Matthias Kaehlcke
     [not found]                         ` <20160916183145.GF62872-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-16 18:48                           ` Mark Brown
2016-09-19 18:39                     ` Doug Anderson
2016-09-24 18:41                       ` Mark Brown
     [not found]                         ` <20160924184133.seh6v6eayt7hwgue-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-26 17:41                           ` Doug Anderson
2016-10-28 18:15                             ` Mark Brown
     [not found]                               ` <20161028181521.ywzmow6bgndfotq3-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-12-12 21:15                                 ` Matthias Kaehlcke
     [not found]                                   ` <20161212211502.GA96889-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-12-13 17:19                                     ` Mark Brown
2016-12-13 20:00                                       ` Doug Anderson
2016-12-13 23:14                                         ` Matthias Kaehlcke [this message]
     [not found]                                         ` <CAD=FV=WhUVeq5GZ5-ae4SxypHGB9jWqgvkO02S=G6Zz6cexRzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-14 13:21                                           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161213231452.GB96889@google.com \
    --to=mka@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=javier@dowhile0.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).