From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Klinger Subject: Re: [PATCH v2 1/2] iio: adc: hx711: Add DT binding for avia,hx711 Date: Wed, 14 Dec 2016 11:34:55 +0100 Message-ID: <20161214103455.GA27362@andreas> References: <20161214095945.GA26511@andreas> <470f0017-2607-d5bd-bcd3-69f892cdc88b@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <470f0017-2607-d5bd-bcd3-69f892cdc88b-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lars-Peter Clausen Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Lars-Peter, Lars-Peter Clausen schrieb am Wed, 14. Dec 11:11: > On 12/14/2016 10:59 AM, Andreas Klinger wrote: > > Add DT bindings for avia,hx711 > > Add vendor avia to vendor list > > > > Signed-off-by: Andreas Klinger > > --- > > .../devicetree/bindings/iio/adc/avia-hx711.txt | 21 +++++++++++++++++++++ > > .../devicetree/bindings/vendor-prefixes.txt | 1 + > > 2 files changed, 22 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > > new file mode 100644 > > index 000000000000..6a4659fc7a4f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.txt > > @@ -0,0 +1,21 @@ > > +* AVIA HX711 ADC chip for weight cells > > + Bit-banging driver > > + > > +Required properties: > > + - compatible: Should be "avia,hx711" > > + - sck-gpios: Definition of the GPIO for the clock > > + - dout-gpios: Definition of the GPIO for data-out > > + See Documentation/devicetree/bindings/gpio/gpio.txt > > + > > +Recommended properties: > > + - gain: Gain select, can be 32, 64 or 128 > > + default is 128 > > If the gain is software programmable it should be exposed by the driver > allowing the application to change it rather than putting it in the devicetree. > There is also a hardware dependency in terms of where to connect the input channel to: - gain 64 and gain 128 are available only on input channel A - gain 32 is only available on input channel B Do you still think, it should be removed from the devicetree? Andreas > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html