devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Koch <mail@alexanderkoch.net>
To: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jiri Kosina <trivial@kernel.org>,
	Alexander Koch <mail@alexanderkoch.net>
Subject: [RFC PATCH v2 0/4] hwmon: adc128d818: Support missing operation modes
Date: Fri, 23 Dec 2016 23:12:01 +0100	[thread overview]
Message-ID: <20161223221205.8825-1-mail@alexanderkoch.net> (raw)

The ADC128D818 offers four different chip operation modes which vary in the
number and measurement types of the available input signals (see datasheet
sec. 8.4.1).

The current version of the driver only supports the default chip operation
mode (mode 0), providing seven analog values and a temperature reading.

This patch series adds support for operation modes 1-3, selectable through
the device tree attribute 'mode':

        adc1: adc128d818@1d {
                compatible = "ti,adc128d818";
                reg = <0x1d>;
                mode = /bits/ 8 <1>;
        };

The changes are transparent as 'mode' defaults to mode 0 which yields the
previous behaviour.


Changes from v1:
 - Add bindings document as first patch
 - Preserve logical atomicity of code changes
 - Improve sysfs device node handling (use is_visible() instead of
   duplicate attribute list)
 - Add trivial code refactoring stage for checkpatch.pl to succeed


Alexander Koch (4):
  devicetree: hwmon: Add bindings for ADC128D818
  hwmon: adc128d818: Implement mode selection via dt
  hwmon: adc128d818: Trivial code style fixup
  hwmon: adc128d818: Support operation modes 1-3

 .../devicetree/bindings/hwmon/adc128d818.txt       |  39 ++++
 drivers/hwmon/adc128d818.c                         | 237 ++++++++++++---------
 2 files changed, 179 insertions(+), 97 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/adc128d818.txt

-- 
2.11.0


             reply	other threads:[~2016-12-23 22:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23 22:12 Alexander Koch [this message]
2016-12-23 22:12 ` [RFC PATCH v2 1/4] devicetree: hwmon: Add bindings for ADC128D818 Alexander Koch
2017-01-03 15:28   ` Rob Herring
2016-12-23 22:12 ` [RFC PATCH v2 2/4] hwmon: adc128d818: Implement mode selection via dt Alexander Koch
2016-12-23 22:12 ` [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Alexander Koch
2016-12-26 10:47   ` Guenter Roeck
     [not found]     ` <650d2371-57da-2494-7628-5a8bc5b756bf-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-12-29 18:22       ` Alexander Koch
     [not found]         ` <3b34c8aa-9d9a-cf88-0d84-8e0d47f9bf44-y2PnNNZjvYd4VEKF+Mn3m16hYfS7NtTn@public.gmane.org>
2016-12-29 19:46           ` Guenter Roeck
2016-12-29 20:30             ` Alexander Koch
     [not found]               ` <3274026c-9575-b85e-54da-dd1cd3c3ce2f-y2PnNNZjvYd4VEKF+Mn3m16hYfS7NtTn@public.gmane.org>
2016-12-30  0:55                 ` Guenter Roeck
2016-12-23 22:12 ` [RFC PATCH v2 4/4] hwmon: adc128d818: Support operation modes 1-3 Alexander Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161223221205.8825-1-mail@alexanderkoch.net \
    --to=mail@alexanderkoch.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).