From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Date: Thu, 29 Dec 2016 11:46:46 -0800 Message-ID: <20161229194646.GA1575@roeck-us.net> References: <20161223221205.8825-1-mail@alexanderkoch.net> <20161223221205.8825-4-mail@alexanderkoch.net> <650d2371-57da-2494-7628-5a8bc5b756bf@roeck-us.net> <3b34c8aa-9d9a-cf88-0d84-8e0d47f9bf44@alexanderkoch.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3b34c8aa-9d9a-cf88-0d84-8e0d47f9bf44-y2PnNNZjvYd4VEKF+Mn3m16hYfS7NtTn@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Koch Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, jdelvare-IBi9RG/b67k@public.gmane.org, trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Dec 29, 2016 at 07:22:12PM +0100, Alexander Koch wrote: > On 12/26/2016 11:47 AM, Guenter Roeck wrote: > > On 12/23/2016 02:12 PM, Alexander Koch wrote: > >> Replace sysfs symbolic file permissions, e.g. 'S_IRUGO', by octal > >> permissions. This fixes checkpatch.pl warnings. > >> > >> Signed-off-by: Alexander Koch > > > > Please do not bother with those warnings and ignore checkpatch. > > We are in the process of doing an automated conversion. > > Okay, so I shall create v3 of the patchset, without these changes. I've > found a typo in the 4th patch so I thought about going v3 anyways. > > I've tested operation modes 1-3 on real hardware today and found no > issues so far, so I hope v3 will have good chances of getting accepted. > Pretty much. One request, though: If there is no configuration data from DT, I would like the driver to read the mode from the chip - if for nothing else, this will let me test all modes, but it also supports the case where the chip is configured by BIOS/ROMMON. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html