From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/4] pinctrl: samsung: Fix the width of PINCFG_TYPE_DRV bitfields for Exynos5433 Date: Fri, 30 Dec 2016 17:09:32 +0200 Message-ID: <20161230150932.q7kadv4ouhdrkqea@kozik-lap> References: <20161230041421.24448-1-andi.shyti@samsung.com> <20161230041421.24448-2-andi.shyti@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: Andi Shyti , Chanwoo Choi , Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Javier Martinez Canillas , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-samsung-soc , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , stable , Andi Shyti List-Id: devicetree@vger.kernel.org On Fri, Dec 30, 2016 at 02:28:52PM +0100, Linus Walleij wrote: > On Fri, Dec 30, 2016 at 5:14 AM, Andi Shyti wrote: > > > From: Chanwoo Choi > > > > This patch fixes the wrong width of PINCFG_TYPE_DRV bitfields for Exynos5433 > > because PINCFG_TYPE_DRV of Exynos5433 has 4bit fields in the *_DRV > > registers. Usually, other Exynos have 2bit field for PINCFG_TYPE_DRV. > > > > Fixes: 3c5ecc9ed353 ("pinctrl: exynos: Add support for Exynos5433") > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Cc: Tomasz Figa > > Cc: Krzysztof Kozlowski > > Cc: Sylwester Nawrocki > > Cc: Linus Walleij > > Cc: Kukjin Kim > > Cc: Javier Martinez Canillas > > Signed-off-by: Chanwoo Choi > > Nominally I think you should sign this off too Andi, as you are in the delivery > path. > > Patch applied for fixes. That has to be signed by Andi... otherwise the chain is broken (and there could be changes added inside). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html