Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jaechul Lee <jcsing.lee@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Andi Shyti <andi.shyti@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-input@vger.kernel.org, galaxyra@gmail.com,
	beomho.seo@samsung.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node
Date: Tue, 3 Jan 2017 18:49:55 +0200	[thread overview]
Message-ID: <20170103164955.2oqyd2du2dom7wym@kozik-lap> (raw)
In-Reply-To: <1483430237-26823-5-git-send-email-jcsing.lee@samsung.com>

On Tue, Jan 03, 2017 at 04:57:17PM +0900, Jaechul Lee wrote:
> Add DT node support for TM2 touchkey device.
> 
> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>

The order of sign-offs should follow the order of "who touched it". I
assume that the real order was like this:
1. Initially create by Beomho,
2. Adjustments by Andi,
3. Final adjustments and sending by you.

If that is correct then the order should be 1->2->3.

Beside of that, patch looks good.

Best regards,
Krzysztof

      parent reply	other threads:[~2017-01-03 16:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170103075733epcas5p48985c789a816f1f2eae84c52e070cc14@epcas5p4.samsung.com>
2017-01-03  7:57 ` [PATCH 0/4] Add touch key driver support for TM2 Jaechul Lee
2017-01-03  7:57   ` [PATCH 1/4] input: Add support for the tm2 touchkey device driver Jaechul Lee
2017-01-03 12:26     ` Javier Martinez Canillas
2017-01-04 14:15     ` Rob Herring
2017-01-03  7:57   ` [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for TM2 Jaechul Lee
2017-01-03 13:11     ` Javier Martinez Canillas
2017-01-03 18:56       ` Dmitry Torokhov
2017-01-03 16:59     ` Krzysztof Kozlowski
2017-01-03  7:57   ` [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other Jaechul Lee
2017-01-03  8:16     ` Andi Shyti
2017-01-03  8:27     ` Krzysztof Kozlowski
2017-01-03  9:58       ` Andi Shyti
     [not found]         ` <20170103095842.h3hl64amje4qv4ts-8vUhnHFVuGn35fTxX1Dczw@public.gmane.org>
2017-01-03 10:01           ` Krzysztof Kozlowski
2017-01-03 10:25             ` Andi Shyti
2017-01-03 11:47               ` Chanwoo Choi
     [not found]                 ` <CAGTfZH3ez4DPTE7-bDeayjhSGxJ_8Mj1MQz1M7O1qhwOGOnmMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-03 11:55                   ` Andi Shyti
     [not found]                     ` <20170103115530.zhjwn7bzmqmumy23-8vUhnHFVuGn35fTxX1Dczw@public.gmane.org>
2017-01-03 12:15                       ` Javier Martinez Canillas
2017-01-03 14:40                         ` Andi Shyti
2017-01-03 14:57                           ` Javier Martinez Canillas
2017-01-03 15:29                           ` Chanwoo Choi
2017-01-03 16:31                             ` Krzysztof Kozlowski
2017-01-03 16:41               ` Krzysztof Kozlowski
2017-01-03  7:57   ` [PATCH 4/4] arm64: dts: exynos: Add tm2 touchkey node Jaechul Lee
2017-01-03 13:14     ` Javier Martinez Canillas
2017-01-03 16:49     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170103164955.2oqyd2du2dom7wym@kozik-lap \
    --to=krzk@kernel.org \
    --cc=andi.shyti@samsung.com \
    --cc=beomho.seo@samsung.com \
    --cc=catalin.marinas@arm.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=galaxyra@gmail.com \
    --cc=javier@osg.samsung.com \
    --cc=jcsing.lee@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox